Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure v9 and v10 examples #727

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

MikeMcC399
Copy link
Collaborator

This PR follows on from PR #725 "Update Cypress v10 tests to 12.3.0".

The label v10 no longer accurately describes examples running under the current version of Cypress 12.x and so the label is v10 is removed. Examples running under Cypress 9.7.0 (which is the last version using Legacy Configuration) now use the label v9 consistently.

  1. The contents of the directory examples/v10, which now contains tests using Cypress 12.3.0, are moved to examples and the empty directory examples/v10 is deleted.
  2. The example workflows and the README.md file are changed to take account of the new working directory location of the Cypress 12.x tests.
  3. Job names and artefacts in the example workflows are changed so that for ones related to tests on Cypress 12.x any suffix -v10 is removed. Job names and artefacts related to tests on Cypress 9.x use the suffix -v9.

@MikeMcC399

This comment was marked as outdated.

v10 removed
v9 is used for Legacy configuration
move v10 examples up one directory level
change working directory in examples
harmonize job names
update README.md
@MikeMcC399 MikeMcC399 marked this pull request as draft January 19, 2023 18:20
@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 19, 2023 18:30
@MikeMcC399
Copy link
Collaborator Author

The failure in example-wait-on.yml logged in https://github.com/cypress-io/github-action/actions/runs/3961225660/jobs/6786408657 was HTTP 429 "too many requests".

I suspect this is a transient error only.

@jaffrepaul
Copy link
Contributor

@MikeMcC399 yeah I've seen some intermittent test failures in the pipeline today with some timeouts. I re ran the above test and it's looking good now. Something to keep an eye on.

@jaffrepaul jaffrepaul merged commit d1d2ac8 into cypress-io:master Jan 19, 2023
@MikeMcC399 MikeMcC399 deleted the remove-v10-label branch January 19, 2023 20:15
@github-actions
Copy link

🎉 This PR is included in version 5.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants