Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to FCCT specs and move examples into existing and new pages #263

Merged
merged 5 commits into from
Mar 31, 2021

Conversation

travier
Copy link
Member

@travier travier commented Mar 26, 2021

Remove ign-passwd & ign-systemd (content already included elsewhere)


Split ign-storage into storage and managing-files pages


Split ign-config-metadata into a standalone Remote config page


Merge using-fcct into producing-ign


Replace fcct-config by a link to the specification


Closes #208

@travier
Copy link
Member Author

travier commented Mar 26, 2021

Made from #239. Thanks a lot @JaimeMagiera for the initial work!

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Thank you both for doing this.

Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, but aside from those, let's land this and then we can improve further. In particular, we'll want to apply the FCCT rename on top of this PR.

Thanks @JaimeMagiera and @travier!

modules/ROOT/pages/managing-files.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/managing-files.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/storage.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/storage.adoc Outdated Show resolved Hide resolved
@travier
Copy link
Member Author

travier commented Mar 31, 2021

Thanks for the review. Updated. Feel free to merge.

@jlebon jlebon merged commit 92dd310 into coreos:master Mar 31, 2021
@travier travier deleted the fcctspec branch March 31, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete FCC spec documentation
4 participants