-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved examples from old spec page to respective topic pages and updat… #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good cleanup. Thanks for handling it!
Remember to update existing pages linking to fcct-config.adoc
.
@@ -60,6 +60,40 @@ An easy way to use `fcct` is to run it in a container with `podman`: | |||
+ | |||
. Use the `example.ign` file to xref:getting-started.adoc[boot FCOS]. | |||
|
|||
The following examples show how to retrieve an Ignition file from a remote source. They are both set to replace the current configuration with a remote Ignition file. | |||
|
|||
=== Downloading FCCT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy-paste error?
Also, I'm not sure this section really belongs here. Maybe we should have a separate page explaining config merge and replace? That functionality seems to trip people up, so it'd be good to explain it more thoroughly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to a separate page. Those are replace examples. I'll add merge after addressing the outstanding issues.
storage: | ||
disks: | ||
- | ||
# Mandatory. We use the World-Wide Number ID of the drive to ensure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the comments are substantive, but they're inconsistent with the other examples on this page...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, wipe all embedded comments?
NOTE: You don't need the `path` or `with_mount_unit` keys; FCOS knows that the root partition is special and will figure out how to find it and mount it. | ||
|
||
.Defining a file system on a RAID storage device |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a sentence or two explaining what the example does. Also, this example should get its own section, rather than being grouped under root filesystem moving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are still some unresolved comments.
For what it's worth, you took on a fairly complex rework of the docs here, and I don't think it's fair to expect you to handle all of the details yourself. Feel free to keep working on this as much as you'd like, but if you get to a point where you want to hand off the work, let me know and I'll be happy to take over.
I'm just plugging away as time permits. If folks are happy to just have it plugged away over the next week or so, I'm happy to keep plugging away. If you or anyone else wants to help or take over, that's fine too. Whatever works best. |
…ed spec link in navigation
That's good. I don't think we're in a hurry for this one. Feel free to comment when you think this is ready for another round of review. |
@JaimeMagiera Are you still working on this? |
Closing in favor of #263 which is based on this one. Thanks a lot @JaimeMagiera for the initial work here. |
Various changes to resolve #208