coreos-boot-edit: run rdcore bind-boot
#1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires: coreos/coreos-assembler#2524 |
bgilbert
reviewed
Nov 5, 2021
overlay.d/05core/usr/lib/dracut/modules.d/35coreos-ignition/coreos-boot-edit.sh
Show resolved
Hide resolved
bgilbert
previously approved these changes
Nov 9, 2021
|
coreos-installer v0.11.0 is in FCOS now, so dropping draft status. Also added tests. |
bgilbert
previously approved these changes
Nov 24, 2021
|
This breaks |
|
This now needs coreos/coreos-installer#700 to correctly handle multipath. |
This binds the bootloader to the bootfs and the bootfs to the rootfs. Part of coreos/fedora-coreos-tracker#976.
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Dec 2, 2021
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the boot mirroring tests. Specifically, it adds coverage for ESP devices discovery in a RAID1 setup (coreos/coreos-installer#700).
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Dec 2, 2021
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the multipath tests. Specifically, it adds coverage for correct handling of the multipathed ESP partition (coreos/coreos-installer#700).
|
OK, this is unblocked now that we have new enough coreos-installer in RHCOS! |
bgilbert
approved these changes
Jan 27, 2022
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Mar 22, 2022
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the boot mirroring tests. Specifically, it adds coverage for ESP devices discovery in a RAID1 setup (coreos/coreos-installer#700).
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Mar 22, 2022
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the multipath tests. Specifically, it adds coverage for correct handling of the multipathed ESP partition (coreos/coreos-installer#700).
jlebon
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Mar 25, 2022
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the boot mirroring tests. Specifically, it adds coverage for ESP devices discovery in a RAID1 setup (coreos/coreos-installer#700).
jlebon
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Mar 25, 2022
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the multipath tests. Specifically, it adds coverage for correct handling of the multipathed ESP partition (coreos/coreos-installer#700).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This binds the bootloader to the bootfs and the bootfs to the rootfs.
Part of coreos/fedora-coreos-tracker#976.