-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grub: support searching for boot by UUID #2524
Conversation
Skipping CI for Draft Pull Request. |
343988d
to
6a352f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure to test this with petitboot; cc @coreos/multi-arch
6a352f7
to
386e1e8
Compare
Just updated the commit message on this because it was referencing the old filename. @Prashanth684 Would you be able to test this on ppc64le? Reach out to me on chat and we can work through it together. |
Restarted CI! There's a new coreos-installer release in FCOS which can leverage this, so would be good to get this in soon. |
So to test this:
diff --cc src/create_disk.sh
index 567eb048a,567eb048a..c2778e541
--- a/src/create_disk.sh
+++ b/src/create_disk.sh
@@@ -321,8 -321,8 +321,10 @@@ els
source ${config_directory}/boot_uuid
fi
if [ -n "${BOOT_UUID}" ]; then
++ echo "Searching boot device by UUID"
search --fs-uuid "${BOOT_UUID}" --set prefix --no-floppy
else
++ echo "Searching boot device by label"
search --label boot --set prefix --no-floppy
fi
fi
diff --cc src/grub.cfg
index eada7d19d,eada7d19d..215271bf5
--- a/src/grub.cfg
+++ b/src/grub.cfg
@@@ -23,8 -23,8 +23,10 @@@ els
source ${config_directory}/boot_uuid
fi
if [ -n "${BOOT_UUID}" ]; then
++ echo "Searching boot device by UUID"
search --fs-uuid "${BOOT_UUID}" --set boot --no-floppy
else
++ echo "Searching boot device by label"
search --label boot --set boot --no-floppy
fi
fi
|
tested on a p8 system and followed above steps and it works. |
This adds support for a `bootuuid.cfg` dropin sitting alongside both the BIOS and EFI GRUB configs to specify the UUID to scan for instead of relying on labels. Part of coreos/fedora-coreos-tracker#976.
386e1e8
to
394f9d2
Compare
Rebased for CI! |
This adds support for a
boot_uuid
dropin sitting alongside both theBIOS and EFI GRUB configs to specify the UUID to scan for instead of
relying on labels.
Part of coreos/fedora-coreos-tracker#976.