-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RAID1 and multipath coverage for bootfs dropins from rdcore bind-boot
#2594
Conversation
considering that let's mark this PR to Draft. |
FWIW, I consciously didn't make it a Draft and instead added the |
oops. I was conflating those two states. |
Cool!
|
To check if a mountpoint is on RAID1, instead of going from the top and querying all devices on the system, we can directly check the type of the device backing the mountpoint.
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the boot mirroring tests. Specifically, it adds coverage for ESP devices discovery in a RAID1 setup (coreos/coreos-installer#700).
This is similar to the tests added in `ext.config.reboot` as part of coreos/fedora-coreos-config#1316, but for the multipath tests. Specifically, it adds coverage for correct handling of the multipathed ESP partition (coreos/coreos-installer#700).
0894d12
to
ff4da51
Compare
Rebased! This should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requires: coreos/fedora-coreos-config#1316
And requires that PR and the associated coreos-installer PR to land in RHCOS.