Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RAID1 and multipath coverage for bootfs dropins from rdcore bind-boot #2594

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Add RAID1 and multipath coverage for bootfs dropins from rdcore bind-boot #2594

merged 3 commits into from
Mar 25, 2022

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Dec 2, 2021 

commit 8282d2be344aa122fc9555c51e2ab261572088ea
Author: Jonathan Lebon <jonathan@jlebon.com>
Date:   Thu Dec 2 12:03:31 2021 -0500

    kola/boot-mirror: simplify check for RAID1 mountpoint

    To check if a mountpoint is on RAID1, instead of going from the top and
    querying all devices on the system, we can directly check the type of
    the device backing the mountpoint.

commit a9fd9e4253d328bcead42c48437f5dd30c8d681c
Author: Jonathan Lebon <jonathan@jlebon.com>
Date:   Thu Dec 2 12:04:08 2021 -0500

    kola/boot-mirror: check bootfs dropins from `rdcore bind-boot`

    This is similar to the tests added in `ext.config.reboot` as part of
    https://github.com/coreos/fedora-coreos-config/pull/1316, but for the
    boot mirroring tests.

    Specifically, it adds coverage for ESP devices discovery in a RAID1
    setup (https://github.com/coreos/coreos-installer/pull/700).

commit 0894d12ea9a2c61e46537286af825193cd78df05
Author: Jonathan Lebon <jonathan@jlebon.com>
Date:   Thu Dec 2 12:14:35 2021 -0500

    kola/multipath: check bootfs dropins from `rdcore bind-boot`

    This is similar to the tests added in `ext.config.reboot` as part of
    https://github.com/coreos/fedora-coreos-config/pull/1316, but for the
    multipath tests.

    Specifically, it adds coverage for correct handling of the multipathed
    ESP partition (https://github.com/coreos/coreos-installer/pull/700).

Requires: coreos/fedora-coreos-config#1316
And requires that PR and the associated coreos-installer PR to land in RHCOS.

@jlebon jlebon mentioned this pull request Dec 2, 2021
Merged
@dustymabe
Copy link
Member

Requires: coreos/fedora-coreos-config#1316
And requires that PR and the associated coreos-installer PR to land in RHCOS.

considering that let's mark this PR to Draft.

@dustymabe dustymabe marked this pull request as draft December 2, 2021 18:42
@jlebon
Copy link
Member Author

jlebon commented Dec 2, 2021

Requires: coreos/fedora-coreos-config#1316
And requires that PR and the associated coreos-installer PR to land in RHCOS.

considering that let's mark this PR to Draft.

FWIW, I consciously didn't make it a Draft and instead added the do-not-merge/hold label because the PR is ready for review. :)

@dustymabe
Copy link
Member

FWIW, I consciously didn't make it a Draft and instead added the do-not-merge/hold label because the PR is ready for review. :)

oops. I was conflating those two states.

@dustymabe dustymabe marked this pull request as ready for review December 2, 2021 19:39
@jlebon
Copy link
Member Author

jlebon commented Dec 2, 2021

Cool! ci/prow/rhcos failing as expected:

 --- FAIL: multipath.day2 (103.96s) 
 --- FAIL: coreos.boot-mirror (162.71s)
    --- FAIL: coreos.boot-mirror/sanity-check (0.98s) 
 --- FAIL: coreos.boot-mirror.luks (282.51s)
    --- FAIL: coreos.boot-mirror.luks/sanity-check (1.19s) 
 --- FAIL: multipath.day1 (126.58s)

@jlebon
kola/boot-mirror: simplify check for RAID1 mountpoint
88abb98 
To check if a mountpoint is on RAID1, instead of going from the top and
querying all devices on the system, we can directly check the type of
the device backing the mountpoint.
@jlebon
kola/boot-mirror: check bootfs dropins from rdcore bind-boot
8c28279 
This is similar to the tests added in `ext.config.reboot` as part of
coreos/fedora-coreos-config#1316, but for the
boot mirroring tests.

Specifically, it adds coverage for ESP devices discovery in a RAID1
setup (coreos/coreos-installer#700).
@jlebon
kola/multipath: check bootfs dropins from rdcore bind-boot
ff4da51 
This is similar to the tests added in `ext.config.reboot` as part of
coreos/fedora-coreos-config#1316, but for the
multipath tests.

Specifically, it adds coverage for correct handling of the multipathed
ESP partition (coreos/coreos-installer#700).
@jlebon jlebon force-pushed the pr/boot-mirror-bootuuid-dropins branch from 0894d12 to ff4da51 Compare March 22, 2022 16:22
@jlebon
Copy link
Member Author

jlebon commented Mar 22, 2022

Rebased! This should be good to go now.

@jlebon jlebon requested a review from bgilbert March 22, 2022 16:22
bgilbert
bgilbert approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit f27b8aa into coreos:main Mar 25, 2022
@jlebon jlebon deleted the pr/boot-mirror-bootuuid-dropins branch March 25, 2022 13:16
@jlebon jlebon mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgilbert bgilbert bgilbert approved these changes

Assignees
No one assigned
Labels
do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlebon @dustymabe @bgilbert