Raise error if check_type=int and conf value is set to bool
#15378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jan 3, 2024
memsharded
pushed a commit
to memsharded/conan
that referenced
this pull request
Jan 8, 2024
…n-io#15378) raise if bool on int check
czoido
added a commit
that referenced
this pull request
Jan 24, 2024
* Git.to_conandata and from_conandata * Raise error if `check_type=int` and conf value is set to `bool` (#15378) raise if bool on int check * auto -FS in AutotoolsToolchain (#15375) * auto -FS in AutotoolsToolchain * moved test * fix winsdk_version bug (#15373) * allow to copy & paste from compact format into conan-lock-add (#15262) * allow to copy & paste from compact format into conan-lock-add * Revert, and just print the %timestamp too * Remove float timestamp from conan list --format=text * Fix test --------- Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * wip --------- Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
czoido
added a commit
that referenced
this pull request
Nov 22, 2024
* refactor: move editables to local api * workspaces back * wip * Git.to_conandata and from_conandata * Raise error if `check_type=int` and conf value is set to `bool` (#15378) raise if bool on int check * auto -FS in AutotoolsToolchain (#15375) * auto -FS in AutotoolsToolchain * moved test * fix winsdk_version bug (#15373) * allow to copy & paste from compact format into conan-lock-add (#15262) * allow to copy & paste from compact format into conan-lock-add * Revert, and just print the %timestamp too * Remove float timestamp from conan list --format=text * Fix test --------- Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * wip * wip * open + add + remove proposal * wip * wip * wip * wip * wip * wip * wip * initial minimal workspace * wip * new test * minor change to make test fail * making workspace decoupled from editables * fix docstring * new test for dynamic workspace * UserWorkpaceAPI * fix test * review --------- Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Raise if
check_type=intand conf value is set tobool.Docs: Omit
I just realized reviewing this #15360 that as
boolis instance ofintwe allow these cases but I think that for these cases it may be more correct to fail (not in the opposite that you may use 0 or 1 to set a bool value)