Feature: Upload parallel #15360
Merged
Feature: Upload parallel #15360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
reviewed
Jan 3, 2024
conan/api/subapi/upload.py
Outdated
| @@ -57,6 +59,40 @@ def upload(self, package_list, remote): | |||
| executor = UploadExecutor(app) | |||
| executor.upload(package_list, remote) | |||
|
|
|||
| def full_upload(self, package_list, remote, enabled_remotes, check_integrity=False, force=False, | |||
There was a problem hiding this comment.
It would be nice to add a docstring here, because this is used for the docs to add documentation for the public API methods.
There was a problem hiding this comment.
Suggestions for a better name? I didn't love it, but also not better ideas. I thought repurposing the old upload() to mean this full one, and rename the old one to execute_upload or upload_transfer or something like that, but I am afraid that this could break users even if this is not public/stable
There was a problem hiding this comment.
I could not think of a better name, but I think I would use upload_full instead of full_upload so it's easier to find.
There was a problem hiding this comment.
Changed to upload_full
czoido
approved these changes
Jan 3, 2024
czoido
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: New
conan uploadcore.upload:parallelfor faster parallel uploads.Docs: conan-io/docs#3540
Close #13224