Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix winsdk_version bug #15373

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 2, 2024

Changelog: Bugfix: Solve winsdk_version bug in CMakeToolchain generator for cmake_minimum_required(3.27).
Docs: Omit

Close #15372

@memsharded memsharded added this to the 2.0.17 milestone Jan 2, 2024
@AbrilRBS AbrilRBS linked an issue Jan 4, 2024 that may be closed by this pull request
@AbrilRBS AbrilRBS merged commit 89a83ef into conan-io:release/2.0 Jan 4, 2024
2 checks passed
@memsharded memsharded deleted the fix/winsdk branch January 4, 2024 08:01
memsharded added a commit to memsharded/conan that referenced this pull request Jan 8, 2024
czoido added a commit that referenced this pull request Jan 24, 2024
* Git.to_conandata and from_conandata

* Raise error if `check_type=int` and conf value is set to `bool` (#15378)

raise if bool on int check

* auto -FS in AutotoolsToolchain (#15375)

* auto -FS in AutotoolsToolchain

* moved test

* fix winsdk_version bug (#15373)

* allow to copy & paste from compact format into conan-lock-add (#15262)

* allow to copy & paste from compact format into conan-lock-add

* Revert, and just print the %timestamp too

* Remove float timestamp from conan list --format=text

* Fix test

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* wip

---------

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
czoido added a commit that referenced this pull request Nov 22, 2024
* refactor: move editables to local api

* workspaces back

* wip

* Git.to_conandata and from_conandata

* Raise error if `check_type=int` and conf value is set to `bool` (#15378)

raise if bool on int check

* auto -FS in AutotoolsToolchain (#15375)

* auto -FS in AutotoolsToolchain

* moved test

* fix winsdk_version bug (#15373)

* allow to copy & paste from compact format into conan-lock-add (#15262)

* allow to copy & paste from compact format into conan-lock-add

* Revert, and just print the %timestamp too

* Remove float timestamp from conan list --format=text

* Fix test

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* wip

* wip

* open + add + remove proposal

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* initial minimal workspace

* wip

* new test

* minor change to make test fail

* making workspace decoupled from editables

* fix docstring

* new test for dynamic workspace

* UserWorkpaceAPI

* fix test

* review

---------

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

winsdk_version_conf with generator issue
2 participants