-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render profile name when using Jinja2 #13721
Render profile name when using Jinja2 #13721
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
||
# default profile should not compute profile_name by default | ||
client.run("install . -pr=default") | ||
assert "conanfile.py: PROFILE NAME: None" in client.out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not? I would expect the profile name to be PROFILE NAME: default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I was not clear on this test. We are using a custom conf to store the profile_name
, but the profile default
is totally clear, so we store nothing.
I just updated it now to provide the default profile with the same content + os=Windows (because the 'build' profile must have a 'os' declared)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conan profiles are not meant to have extensions afaik, but there sure is someone out there using them so +1 :)
Other than @memsharded's comments it lgtm
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Parse the profile file name (including its extension) as profile_name for Jinja2 context.
Changelog: Feature: Render the profile file name as profile_name
Docs: conan-io/docs#3180
closes #13698
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.