-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add profile_name variable to profile rendering #13698
Comments
Thanks for your suggestion.
|
Implemented in #13721 for next 2.0.5 |
Hi, @memsharded |
In principle new features like this are not backported to 1.X releases.
Could you please elaborate on this? If this is a new feature, it is not possible that you were relying on it on Conan 1.X. It should be possible to upgrade your 1.X profiles approach to 2.0, and then improve the profiles in 2.0 with the new feature, isn't it? |
Almost all our teams use conan 1. The problem is that we have to wait (idk for how long) until all our teams migrate to conan 2 before being able to use this feature. I totally understand that you don't want to port all features to conan 1 but since this feature looks simple (correct me if I'm wrong), I've had a hope that it will be easy to port it to conan 1. This will unblock some our work and remove dependency on teams. |
I understand. It is not a single simple feature backport the concerning one, but the accumulation of many of them (plus documentation, fixing some possible bugs, the conflicts that inevitably happen when merged back to 2.0 branches, etc), so it is important to define some guidelines what can the team backports and what not. Maybe if it is important to you, and you want to contribute the backport PR to the |
I'll give it a try. Don't know how long will it take tho. |
@memsharded Just FYI, we had an internal discussion and we decided not in invest into improving conan 1. |
Thanks for the feedback. We haven't had the chance either to even consider backporting this, the backlog of other priorities is too big :(, sorry about that. |
What is your suggestion?
Feature request: Please add
profile_name
variable into profile templates - this will help a lot for the use case with large number of profiles.In our use case, we have dozens of profiles that have pattern-style names like
<os>_<compiler>_<version>_<arch>
. Since profile name can be parsed, it's easy to script profile generation.Here is what we have right now:
We have dozens of profiles where each profile (
.jinja
file) has the same code with the only difference in profile name, for example windows_msvc_v1933_x86.jinja:Here is the profile generator _profile_generator.jinja (a bit simplified):
As soon as
profile_name
variable is available, we can make all<os>_<compiler>_<version>_<arch>.jinja
files to be symlinks to a profile generator that can parse globalprofile_name
variable and include corresponding fragments. The benefit would be in removing of the maintenance burden of slightly different content of.jinja
files.Have you read the CONTRIBUTING guide?
The text was updated successfully, but these errors were encountered: