Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[profile] Add profile_name attribute to Jinja context #3180

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

uilianries
Copy link
Member

Add the profile_name based on the original need, creating a generic profile that uses its own file name to define its settings.

Related to conan-io/conan#13721

@memsharded memsharded added this to the 2.0.5 milestone Apr 19, 2023
@uilianries
Copy link
Member Author

@memsharded I needed to update the parse, as it will include .jinja as part of the profile_name and need to exclude it for parsing the profile settings. Otherwise, the compiler.version would be 12.jinja

@uilianries uilianries requested a review from memsharded April 19, 2023 15:10
@memsharded
Copy link
Member

This cannot be merged, because it goes to release/2.0, but belongs to a feature not yet released (2.0.5), so we need to wait for merge (or please target the PR to develop2 instead)

@uilianries uilianries changed the base branch from release/2.0 to develop2 April 21, 2023 09:42
@uilianries uilianries changed the base branch from develop2 to release/2.0 April 21, 2023 09:43
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries force-pushed the feature/profile-name branch from a72b68d to 280b405 Compare April 21, 2023 09:47
@uilianries uilianries changed the base branch from release/2.0 to develop2 April 21, 2023 09:47
@uilianries
Copy link
Member Author

@memsharded fixed the base branch to develop2. Of course, I needed to use forced push to correct the base. Please, review it again.

@uilianries uilianries requested a review from AbrilRBS April 21, 2023 09:48
@memsharded memsharded merged commit baf32c3 into conan-io:develop2 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants