[magnum] Add recipe #7095
[magnum] Add recipe #7095
Conversation
jgsogo
commented
Aug 28, 2021
jgsogo
commented
- [corrade] Add components + build_module + modernize #6290
- [vulkan-loader] Up requirements #6942
- [sdl] Add linux + enable nas + enable wayland #6387
- [nas] Network audio system #6388
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: SSE4 <tomskside@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
@madebr , now we probably have something to review. I've renamed the options (no more |
| if self.settings.os == "Linux": | ||
| del self.options.cgl_context | ||
| del self.options.windowless_cgl_application | ||
| del self.options.wgl_context |
There was a problem hiding this comment.
I think wgl_context (and every option containing wgl) is Windows-only:
https://github.com/mosra/magnum/blob/03b7adf71b1b50d2d1d2064b4a185355ee19dd5f/CMakeLists.txt#L167
There was a problem hiding this comment.
I can build wgl_context in Macos. TBH, I have no idea if it is usable or not. I disabled only the options that were failing for each OS, I find it very hard to reproduce the logic encoded in the build system.
| "windowless_cgl_application": True, | ||
| "windowless_egl_application": True, | ||
| "windowless_glx_application": True, | ||
| "windowless_ios_application": True, | ||
| "windowless_wgl_application": True, | ||
| "windowless_windows_egl_application": True, | ||
|
|
||
| "cgl_context": True, | ||
| "egl_context": True, | ||
| "glx_context": True, | ||
| "wgl_context": True, |
There was a problem hiding this comment.
Do we care about some illegal option combinations/dependencies?
e.g. windowless_cgl_application is connected to cgl_context, likewise for egl, glx, wgl
There was a problem hiding this comment.
I see the project generates a egl/glx/wgl objects library, and it only generates the actual library when xxx_context is True. So, we can have xxx_context=False and the xxx_application=True and it will work.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
|
All green in build 28 (
|
|
@madebr @SSE4 do you think I should try to reproduce more accurately the logic encoded in the build-system? Right now I'm basically removing options that make the build fail and running some evident checks between options. Logic in the library's build-system files is much more complex... On one hand, I prefer to merge this recipe and the future will help: people building with other combinations of options, maybe new library versions with different logic,... I understand it is inconvenient to come across a build error while building, that it´s the role of the package manager to check these options before trying to build, but we all know that right now the logic is written by the author's library in the build-system files and we can only try to reproduce it in the recipes. |
|
I think it's fine. It's a hard exercise to check everything. |
|
Fast bot 🙀 I agree. If someone needs more options they can contribute back to fix them or improve availability... let's give something for now! |
