-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[corrade] Add components + build_module + modernize #6290
[corrade] Add components + build_module + modernize #6290
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Kindly requesting another review round. Thanks! |
conan_basic_setup() | ||
conan_basic_setup(TARGETS) | ||
|
||
find_package(Corrade REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr adds the Corrace::rc
excutable target.
Do we want to test it?
Does it work with shared libs on Linux/Windows/Macos in cmake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you usually test such kinds of targets? do you have a good example?
I mean, you don't usually do target_link_library(${PROJECT_NAME} <my_executable_target>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not adding an rc
component, amI? Conan is not creating that target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're creating the target in conan-corrade-vars.cmake
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cmake.org/cmake/help/latest/command/execute_process.html
🤔
get_target_property(CORRADE_RC_PROGRAM Corrade::rc IMPORTED_LOCATION)
execute_process(${CORRADE_RC_PROGRAM} --version) # Idk the command line but just a suggestions
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…r-index into corrade-fix-modernize
If |
Specify library name and version: corrade