embag: add new recipe #17575
Merged
embag: add new recipe #17575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 93b40f8embag/0.0.42 |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
memsharded
reviewed
May 25, 2023
3 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Aug 18, 2023
uilianries
previously approved these changes
Aug 18, 2023
This comment has been minimized.
This comment has been minimized.
Otherwise would need to add /Zc:__cplusplus to exported cxxflags.
This comment has been minimized.
This comment has been minimized.
recipes/embag/all/conanfile.py
Outdated
| def _patch_sources(self): | ||
| # Disable a C++11 workaround that is broken on MSVC | ||
| replace_in_file(self, os.path.join(self.source_folder, "lib", "util.h"), | ||
| "#if __cplusplus < 201402L", "#if false") |
There was a problem hiding this comment.
@valgur I think the best way to do that is by adding this as a patch field in the conandata.yml. It would be good to have it there in case of opening a PR upstream to add this patch in the future.
This comment has been minimized.
This comment has been minimized.
|
I just restarted this PR in the CI build. The error involving Windows path is fixed now. |
franramirez688
approved these changes
Sep 4, 2023
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 7 (
|
uilianries
approved these changes
Sep 4, 2023
ericLemanissier
pushed a commit
to ericLemanissier/conan-center-index
that referenced
this pull request
Sep 15, 2023
* embag: add new recipe * embag: set min cxx_standard to 11 * embag: add missing 'm' system lib * embag: bump min c++ std to 14 * embag: fix a portability bug * embag: drop test_v1_package * embag: transitive_libs not required for boost * embag: get rid of patch, add review suggestion * embag: revert to using a patch Otherwise would need to add /Zc:__cplusplus to exported cxxflags. * embag: get rid of the patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: embag/0.0.42
Resolves #17574.