Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Possible Bazel toolchain deficiencies #14519

Closed
valgur opened this issue Aug 18, 2023 · 3 comments · Fixed by #14958
Closed

[bug] Possible Bazel toolchain deficiencies #14519

valgur opened this issue Aug 18, 2023 · 3 comments · Fixed by #14958
Assignees
Milestone

Comments

@valgur
Copy link
Contributor

valgur commented Aug 18, 2023

Copying over some observations regarding the Bazel generators / build system from one of the few CCI recipes targeting a Bazel-based project: conan-io/conan-center-index#17575 (comment)

  • The tools.build:compiler_executables config values were not being applied.
  • The cppstd value was not being translated into a --std=c++14 build flag, as is done with CMakeToolchain. I might simply be using the BazelToolchain incorrectly, though.
  • There's no obvious way (to me at least) how the build results should be installed for package() using Bazel. I added some explicit copy() commands in the conanfile for this.

Conan version: 2.0.4

Steps to reproduce

  1. Clone embarktrucks/embag@master...valgur:embag:conan
  2. Run conan create on the recipe.
@memsharded
Copy link
Member

Thanks @valgur for the report.
It is very likely that the Bazel integration is far less mature than other integrations. @franramirez688 has pending some work to revisit the integration and some of the open tickets around it.

@franramirez688
Copy link
Contributor

Hi @valgur

Thanks a lot for reporting this!

All your points should be solved by #14958, but the latest one:

There's no obvious way (to me at least) how the build results should be installed for package() using Bazel. I added some explicit copy() commands in the conanfile for this.

Bazel has no explicit mechanism to do that, so it's not still obvious to make it automatically. I hope that future versions of Conan can automatize it in a better way.

@valgur
Copy link
Contributor Author

valgur commented Oct 26, 2023

Hi @valgur

Thanks a lot for reporting this!

All your points should be solved by #14958, but the latest one:

There's no obvious way (to me at least) how the build results should be installed for package() using Bazel. I added some explicit copy() commands in the conanfile for this.

Bazel has no explicit mechanism to do that, so it's not still obvious to make it automatically. I hope that future versions of Conan can automatize it in a better way.

Thank you for the hard work on this, @franramirez688! Looks like everything I previously mentioned has been addressed and the issue can be closed.

@valgur valgur closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants