safety: add longitudinal pre-enable state for brake at a standstill #1123
+72
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
commented
Oct 28, 2022
board/safety.h
Outdated
| @@ -85,7 +85,7 @@ int safety_fwd_hook(int bus_num, CANPacket_t *to_fwd) { | |||
| } | |||
|
|
|||
| bool get_longitudinal_allowed(void) { | |||
| return controls_allowed && !gas_pressed_prev; | |||
| return controls_allowed && !gas_pressed_prev && !brake_pressed_prev; | |||
There was a problem hiding this comment.
Will need to allow braking on cars that are gas/brake controlled and not acceleration controlled.
On both GM and certain Honda, once you release the brake the car will lurch forward as openpilot's brake request ramps up.
sshane
changed the title
sshane
commented
Dec 1, 2022
sshane
commented
Dec 3, 2022
| return controls_allowed && !gas_pressed_prev; | ||
| } | ||
|
|
||
| bool get_accel_allowed(void) { |
There was a problem hiding this comment.
let's make this name less ambiguous, such as gas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new pre-enable state when enabling at a standstill with brake depressed. Allows brake and negative accel to 0 accel, blocks positive accel, gas, interceptor.
Pre-reqs (so this change isn't unmaintainable):