Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block actuation while in the pre-enable state #843

Closed
adeebshihadeh opened this issue Jan 28, 2022 · 2 comments
Closed

Block actuation while in the pre-enable state #843

adeebshihadeh opened this issue Jan 28, 2022 · 2 comments
Labels
car safety vehicle-specific safety code

Comments

@adeebshihadeh
Copy link
Contributor

Currently, only the Honda safety handles this.
@adeebshihadeh adeebshihadeh added the car safety vehicle-specific safety code label Jan 28, 2022
@adeebshihadeh adeebshihadeh mentioned this issue Mar 29, 2022
Closed
@adeebshihadeh adeebshihadeh mentioned this issue Aug 27, 2022
Closed
@adeebshihadeh
Copy link
Contributor Author

@sshane is this done?

@sshane
Copy link
Contributor

sshane commented Nov 11, 2023

I believe the topic of this PR was to enforce pre-enable safety when enabling with gas pressed, however we now allow steering in pre-enable state and longitudinal pre-enabling is done with the common checks in safety.h. Relevant PRs: #884 and #1121

We still need to block actuation when pre-enabling at a stop in is this draft PR which I'm trying to clean up: #1123

@sshane sshane closed this as completed Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
car safety vehicle-specific safety code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adeebshihadeh @sshane