refactor torque measurement reset on violation #1046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntegan1
commented
Aug 27, 2022
ntegan1
commented
- removes some duplication
- allows for cleaner custom steer request mismatch handling (useful when updating toyota-steer-faults2)
|
This isn't necessary; GM will use the common steer checks once #843 is done. |
master...ntegan1:panda:toyota-steer-faults2-update the main idea was to allow for updating toyota steer faults safety with the abstract motor torque limit checks |
|
It is currently necessary. Some day in the future when #843 happens it may not be necessary |
ntegan1
added a commit
to ntegan1/panda
that referenced
this pull request
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.