Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transparency handling for webp #3692

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Fix transparency handling for webp #3692

merged 2 commits into from
Sep 28, 2020

Conversation

michalsn
Copy link
Member

Description
Fixes #3690

Checklist:

  • Securely signed commits
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Sep 28, 2020

Maybe we should make the list of IMAGE_TYPE that supports transparency a class variable or something, so we don't have to keep updating this function (e.g. JPEG2000 supports it, might need to add down the road).

MGatner
MGatner approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@MGatner MGatner merged commit 9292923 into codeigniter4:develop Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image format webp is not preserve transparent
3 participants
@michalsn @MGatner @orionstar