Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image format webp is not preserve transparent #3690

Closed
amigoscs opened this issue Sep 28, 2020 · 0 comments · Fixed by #3692
Closed

Image format webp is not preserve transparent #3690

amigoscs opened this issue Sep 28, 2020 · 0 comments · Fixed by #3692
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@amigoscs
Copy link

Image format webp is not preserve transparent during resize.

I found the problem in the code /system/Images/Handlers/GDHandler.php

`
Line 249

...
if ($this->image()->imageType === IMAGETYPE_PNG) // png we can actually preserve transparency
{
imagealphablending($dest, false);
imagesavealpha($dest, true);
}
...
`

fixing the code on this one solves the problem

... if ($this->image()->imageType === IMAGETYPE_PNG || $this->image()->imageType === IMAGETYPE_WEBP) ...

Please keep this issue in mind in future releases. Thanks!

@amigoscs amigoscs added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant