Merge pull request #3692 from michalsn/fix/webp-transparent

Fix transparency handling for webp
codeigniter4 · Sep 28, 2020 · 9292923 · 9292923
2 parents e7bb006 + 25cb7b4
commit 9292923
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/system/Images/Handlers/BaseHandler.php b/system/Images/Handlers/BaseHandler.php
@@ -132,6 +132,16 @@ abstract class BaseHandler implements ImageHandlerInterface
 		'shadowOffset' => 3,
 	];
 
+	/**
+	 * Image types with support for transparency.
+	 *
+	 * @var array
+	 */
+	protected $supportTransparency = [
+		IMAGETYPE_PNG,
+		IMAGETYPE_WEBP,
+	];
+
 	/**
 	 * Temporary image used by the different engines.
 	 *

diff --git a/system/Images/Handlers/GDHandler.php b/system/Images/Handlers/GDHandler.php
@@ -246,7 +246,8 @@ protected function process(string $action)
 
 		$dest = $create($this->width, $this->height);
 
-		if ($this->image()->imageType === IMAGETYPE_PNG) // png we can actually preserve transparency
+		// for png and webp we can actually preserve transparency
+		if (in_array($this->image()->imageType, $this->supportTransparency, true))
 		{
 			imagealphablending($dest, false);
 			imagesavealpha($dest, true);