Fix a compilation warning in TracksterLinkingbySkeletons in DBG_X

[makortel]

PR description:

Fixes #45998

Resolves cms-sw/framework-team#1022

PR validation:

None

[cmsbuild]

cms-bot internal usage

[iarspider]

please test for CMSSW_14_2_DBG_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45999/41772

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• RecoHGCal/TICL (reconstruction, upgrade)

@jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @missirol, @rovere, @sameasy, @sobhatta, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

fixes #45998

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cae92/41504/summary.html
COMMIT: 7aa19b3
CMSSW: CMSSW_14_2_DBG_X_2024-09-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45999/41504/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider Update classes inheriting from ROOT::Minuit2::FCNBase to account for changes in ROOTmaster #45965
• @fwyzard Split ZVertexSoA in a run-time sized PortableMultiCollection #45887
• @mmusich protect SiStripTkMaps in case of empty inputs, also test for it in unit tests #45966
• @IzaakWN Fix small typo in makePileupJSON.py: runNumber → run #45989
• @perrotta Update in autoCond 141X data and MC GTs for HI, and also synchronize them with the updated 140X ones #45990
• @civanch [SIM] improved initialisation #45986
• @arizzi Adding subGenJets to NanoGEN #45985
• @lguzzi customiser for alpaka patatrack pixel seeding for phase2 #45508
• @mmusich migrate calotowers creation code to use EcalPFRecHitThresholds #45803

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cae92/41504/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cae92/41504/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test test_dumpRecoGeometry had ERRORS

Comparison Summary

Summary:

• You potentially added 9048127 lines to the logs
• Reco comparison results: 37709 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 231581
• DQMHistoTests: Total nulls: 89
• DQMHistoTests: Total successes: 3099468
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1.039 KiB( 43 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.070 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13034.0 ): -0.908 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 141.042 ): -0.012 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.044 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.046 ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 250202.181 ): -0.059 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.010 KiB SiStrip/MechanicalView
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: found differences in 10 / 42 workflows

[makortel]

The unit test failure

Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 13-Sep-2024 17:59:39.664 CEST


A fatal system signal has occurred: external termination request
The following is the call stack containing the origin of the signal.


---> test test_dumpRecoGeometry had ERRORS
Fri Sep 13 18:00:35 CEST 2024
TestTime:3600

looks like it was killed because of running too long. @smuzaffar do you agree? Maybe this test should be split into a few in order to run the (sub)tests in parallel?

[makortel]

@cmsbuild, please test

Let's try again.

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cae92/41602/summary.html
COMMIT: 7aa19b3
CMSSW: CMSSW_14_2_X_2024-09-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45999/41602/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 83 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 2871
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328267
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[jfernan2]

Not sure if the test is OK, bot complains about some unit test was failed

[smuzaffar]

looks like it was killed because of running too long. @smuzaffar do you agree? Maybe this test should be split into a few in order to run the (sub)tests in parallel?

yes @makortel , this unit tests takes over an hour for DBG IBs and around 15-20mins for normal IBs. It will nice to break it in multiple if possible.

[smuzaffar]

ignore tests-rejected with ib-failure

unit test failure for DBG is not related to this change.

[makortel]

looks like it was killed because of running too long. @smuzaffar do you agree? Maybe this test should be split into a few in order to run the (sub)tests in parallel?

yes @makortel , this unit tests takes over an hour for DBG IBs and around 15-20mins for normal IBs. It will nice to break it in multiple if possible.

I opened an issue #46053

[jfernan2]

+1

[makortel]

@cms-sw/upgrade-l2 Could you review and sign? Thanks!

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1