Update classes inheriting from ROOT::Minuit2::FCNBase to account for changes in ROOTmaster

[iarspider]

PR description:

ROOT::Minuit2::FCNBase interface changed in root-project/root@63636f6:

[Minuit2] Use std::span instead of std::vector const& for parameters

Use std::span instead of std::vector const& for function parameters
in Minuit2.

The motivation is that std::span is more general. If the function
takes a std::vector const&, the inputs are forced to be allocated on
the heap. So if one wants to call functions with constant size or even
scalar input, that would cause a large overhead.

This overhead can be avoided when generalizing with std::span.

The standalone Minuit2 build files were also changed to consider the
std::span backport to C++17 that is already in ROOT.

This PR updates classes that inherit from it.

PR validation:

Bot tests.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45965/41720

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• OnlineDB/CSCCondDB (db)
• RecoVertex/BeamSpotProducer (reconstruction, alca)

@cmsbuild, @consuegs, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanChyczynski, @JanFSchulte, @PonIlya, @VinInn, @VourMa, @dgulhan, @fabiocos, @francescobrivio, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

Pull request has been put on hold by @iarspider
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45965/41722

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45965/41722/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45965/41722/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45965/41725

[cmsbuild]

Pull request #45965 was updated. @cmsbuild, @consuegs, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @saumyaphor4252 can you please check and sign again.

[iarspider]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dfba33/41467/summary.html
COMMIT: 4b5e99d
CMSSW: CMSSW_14_2_X_2024-09-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45965/41467/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 170 lines from the logs
• Reco comparison results: 105 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3437830
• DQMHistoTests: Total failures: 2910
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3434900
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 197 log files, 168 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[smuzaffar]

@cms-sw/alca-l2 @cms-sw/db-l2 can you please review this pr. it contains changes needed for latest root development

[smuzaffar]

This PR updates classes that inherit from it. This change is probably not backwards-compatible.

I think this is not true any more. The changes in this PR are backwards-compatible ... right?
@saumyaphor4252 , @perrotta and @consuegs integration of this will allow us to test latest root changes e.g. they have recently intergated llvm 18 in to root and we would like to test that as soon as possible.

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[smuzaffar]

@iarspider , this isnot working for ROOT 6.32 IBs. Are you sure this change went in to root 6.32 branch too?

[smuzaffar]

I have opened #46006