Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test_dumpRecoGeometry run faster #46080

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 20, 2024

PR description:

The test_dumpRecoGeometry test script runs many cmsRun jobs and can time out in PR tests (see e.g. #45999 (comment)).
The script is refactored such that some of these jobs can run in parallel.

  • one job per "year" (Run1 2015 2017 2026)
  • the 2026 case (as it has an internal nested loop which is the most consuming part of the test) is run with 4 parallel cmsRun executions.

This resolves #46053

PR validation:

scram b runtests runs successfully:

>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
Creating test log file logs/el9_amd64_gcc12/testing.log
Pass    7s ... Fireworks/Geometry/test_dumpRecoGeometry_2015
Pass   10s ... Fireworks/Geometry/test_dumpRecoGeometry_2017
Pass  177s ... Fireworks/Geometry/test_dumpRecoGeometry_2026
Pass    6s ... Fireworks/Geometry/test_dumpRecoGeometry_Run1
>> Test sequence completed for CMSSW CMSSW_14_2_X_2024-09-19-2300

in about 3 and $1/2$ minutes, whereas before this PR it took around 10 minutes to complete.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Fireworks/Geometry (visualization)

@Dr15Jones, @alja, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2024

@cmsbuild, please test

@alja
Copy link
Contributor

alja commented Sep 20, 2024

+1

@alja
Copy link
Contributor

alja commented Sep 20, 2024

@mmusich Thank you!

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370a60/41677/summary.html
COMMIT: da7309c
CMSSW: CMSSW_14_2_X_2024-09-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46080/41677/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331158
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3331138
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c22ea8b into cms-sw:master Sep 21, 2024
11 checks passed
@mmusich mmusich deleted the mm_fix_test_dumpRecoGeometry branch September 21, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_dumpRecoGeometry test should be split into multiple scripts
4 participants