Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Backport of #45820: Change ScoutingNano event content #45949

Merged

Conversation

patinkaew
Copy link
Contributor

PR description:

Backport of #45820 from 14_2_X to allow tests for ScoutingNano central production at T0 with 14_1_X release. This backport is also intended to keep release consistent because backport of #44970, #45820 to 14_0_X will follow for actual data-taking release, so we eventually have #44970, #45820 in subsequent releases from 14_0_X.

Note: #44970 was originally merged to 14_1_X, so we don't need backport for that PR for 14_1_X.

The original PR changes ScoutingNano event content by dropping PF candidates, dropping tracks, adding PFJet clustered at HLT, removing tasks related to TrigObj table, and additional minor changes. The final event size is <2 kB/event for default ScoutingNano configuration, containing only scouting objects without offline objects and without gen info (MC).

PR validation:

Standard tests scram b runtests and runTheMatrix.py -l limited -i all --ibeos passed when validating #45820. ScoutingNano event size report comparison was done in [1]. Original PR tests confirm that these size reports and also observe event size reduced by ~85%.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #45820 to CMSSW 14_1_X release.

[1] https://indico.cern.ch/event/1441452/#preview:5119073

…ts particleNet branch, fix incorrect orders of particleNet tags for reclustered ak8 jets, rename ScoutingTrack__lambda to ScoutingTrack_lambda_
…icleScoutingTable), drop scouting tracks, add scouting PFJet (clustered at HLT)
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2024

A new Pull Request was created by @patinkaew for CMSSW_14_1_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2024

cms-bot internal usage

@patinkaew
Copy link
Contributor Author

Tagging HLT Scouting convenors: @silviodonato @elfontan.

@hqucms
Copy link
Contributor

hqucms commented Sep 7, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Sep 7, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02f479/41389/summary.html
COMMIT: 7bacaa5
CMSSW: CMSSW_14_1_X_2024-09-07-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45949/41389/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328391
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328368
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 28993 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 54921
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 54921
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 2.788 2.788 0.000 ( +0.0% ) 3.36 3.26 +3.0% 6.038 6.033
2500.002 2.901 2.901 0.000 ( +0.0% ) 2.97 2.92 +1.7% 6.395 6.392
2500.003 2.848 2.848 0.000 ( +0.0% ) 3.10 3.02 +2.4% 6.351 6.362
2500.011 1.450 1.450 0.000 ( +0.0% ) 5.81 5.59 +3.9% 2.403 2.397
2500.012 1.909 1.909 0.000 ( +0.0% ) 3.19 3.09 +3.3% 2.598 2.589
2500.013 1.765 1.765 0.000 ( +0.0% ) 4.60 4.44 +3.7% 2.503 2.503
2500.021 0.022 0.022 0.000 ( +0.0% ) 1.00 0.93 +7.3% 2.234 2.249
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.95 0.88 +8.2% 2.222 2.216
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.97 0.88 +10.6% 2.202 2.174
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.73 0.67 +9.2% 2.317 2.307
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.88 0.81 +8.6% 2.326 2.312
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.92 0.85 +7.5% 2.268 2.262
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.82 0.76 +7.9% 2.360 2.333
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.83 0.76 +8.9% 2.354 2.359
2500.101 2.646 2.646 0.000 ( +0.0% ) 9.06 8.58 +5.6% 6.269 6.888
2500.111 1.330 1.330 0.000 ( +0.0% ) 21.05 19.68 +6.9% 2.217 2.212
2500.112 1.735 1.735 0.000 ( +0.0% ) 15.04 13.26 +13.4% 2.102 2.107
2500.131 0.747 5.194 -4.447 ( -85.6% ) 18.64 14.92 +24.9% 1.494 1.541
2500.201 2.478 2.478 0.000 ( +0.0% ) 7.68 7.27 +5.8% 5.505 6.123
2500.211 1.592 1.592 0.000 ( +0.0% ) 18.01 16.60 +8.5% 2.101 2.090
2500.212 2.033 2.033 0.000 ( +0.0% ) 14.01 13.24 +5.8% 2.130 2.125
2500.221 2.006 2.006 0.000 ( +0.0% ) 7.90 7.24 +9.1% 2.274 2.267
2500.222 3.072 3.072 0.000 ( +0.0% ) 7.55 6.97 +8.3% 2.328 2.293
2500.223 8.888 8.888 0.000 ( +0.0% ) 2.81 2.65 +6.1% 2.357 2.304
2500.224 5.515 5.515 0.000 ( +0.0% ) 1.12 1.05 +6.7% 2.127 2.563
2500.225 5.533 5.533 0.000 ( +0.0% ) 1.02 0.97 +4.7% 2.078 2.410
2500.226 2.973 2.973 0.000 ( +0.0% ) 7.30 6.98 +4.6% 2.292 2.284
2500.227 1.437 8.972 -7.535 ( -84.0% ) 12.00 9.55 +25.6% 1.394 1.373
2500.231 1.407 1.407 0.000 ( +0.0% ) 13.82 13.04 +6.0% 1.931 1.940
2500.232 2.145 2.145 0.000 ( +0.0% ) 13.86 12.89 +7.5% 2.019 1.997
2500.233 4.670 4.670 0.000 ( +0.0% ) 4.86 4.62 +5.2% 2.014 2.015
2500.234 3.307 3.307 0.000 ( +0.0% ) 1.50 1.43 +4.5% 1.783 2.057
2500.235 3.317 3.317 0.000 ( +0.0% ) 1.41 1.33 +5.5% 1.822 2.077
2500.236 2.085 2.085 0.000 ( +0.0% ) 13.24 12.81 +3.4% 1.509 2.019
2500.237 1.016 7.977 -6.961 ( -87.3% ) 17.46 13.97 +25.0% 1.416 1.421
2500.241 9.405 9.405 0.000 ( +0.0% ) 4.02 3.80 +5.8% 1.752 1.880
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.92 0.86 +7.0% 1.591 1.725
2500.243 2.712 2.712 0.000 ( +0.0% ) 7.14 7.66 -6.8% 1.052 1.060
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.55 0.53 +2.4% 1.695 1.605
2500.245 823.224 823.224 0.000 ( +0.0% ) 0.76 0.70 +9.5% 1.672 1.536
2500.901 1.749 1.749 0.000 ( +0.0% ) 17.07 20.71 -17.6% 1.759 1.829
2500.902 1.598 1.598 0.000 ( +0.0% ) 20.27 20.64 -1.8% 1.754 1.760
2500.911 13.931 13.931 0.000 ( +0.0% ) 3.23 2.96 +9.3% 1.075 1.082
2500.912 0.240 0.150 0.090 ( +59.9% ) 1.37 1.07 +28.3% 0.966 0.968
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.12 1.17 -4.8% 0.969 0.971

@hqucms
Copy link
Contributor

hqucms commented Sep 7, 2024

+1

@hqucms
Copy link
Contributor

hqucms commented Sep 7, 2024

backport of #45820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ec147e1 into cms-sw:CMSSW_14_1_X Sep 9, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants