Add ScoutingMuonNoVtx and ScoutingMuonVtx in Run3Scouting Nano starting from 2024 data taking #44970

patinkaew · 2024-05-14T11:26:48Z

PR description:

This PR adds two versions of scouting muon collections, ScoutingMuonNoVtx and ScoutingMuonVtx, following this change CMSHLT-3089:Add hltScoutingMuonPackerVtx to Scouting EventContent.

This fixes issue Missing "hltScoutingMuonPacker" in ScoutingNANO using recent Run-3 data#44817.

This PR also introduces run3_scouting_nanoAOD_post2023 Modifier used to modify configuration and top level Run3_post2023 ModifierChain based on Run3 with run3_scouting_nanoAOD_post2023 Modifier.

PR validation:

Tested by producing scouting NanoAOD from a 2024 scouting HLTSCOUT datatier file using the following cmsDriver.py command:

cmsDriver.py step2 -s NANO:@Scout --process NANO \
--data --eventcontent NANOAOD --datatier NANOAOD -n 10000 \
--era Run3_post2023 --conditions auto:run3_data --filein fileIN.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, but backport to 140X will follow.

cc: @elfontan @karim @silviodonato @vlimant

cmsbuild · 2024-05-14T11:27:16Z

cms-bot internal usage

cmsbuild · 2024-05-14T11:33:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44970/40251

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532, add Era_Run3_2024, Era_Run3_2025, Tier0 reco scenario for 2024, and change default era in PyReleaseValidation #43761

cmsbuild · 2024-05-14T11:33:31Z

A new Pull Request was created by @patinkaew for master.

It involves the following packages:

Configuration/Eras (operations)
Configuration/StandardSequences (operations)
PhysicsTools/NanoAOD (xpog)

@rappoccio, @hqucms, @fabiocos, @vlimant, @antoniovilela, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @slomeo, @fabiocos, @felicepantaleo, @VourMa, @VinInn, @sameasy, @missirol, @makortel, @mtosi, @mmusich, @gpetruc, @Martin-Grunewald, @JanFSchulte, @AnnikaStein, @dgulhan this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

vlimant · 2024-05-14T11:54:47Z

Configuration/Eras/python/Modifier_run3_scouting_nanoAOD_post2023_cff.py

@@ -0,0 +1,3 @@
+import FWCore.ParameterSet.Config as cms
+
+run3_scouting_nanoAOD_post2023 = cms.Modifier()


please remove the intermediate run3_scouting_nanoAOD_post2023 modifier, unless there's a citable policy to do so

Sorry I might be completely wrong here. From here, I understand that top level like Run3 as ModifierChain has no method like toModify or toReplaceWith. Therefore, I create run3_scouting_nanoAOD_post2023 as Modifier and call toReplaceWith to replace the tables.

vlimant · 2024-05-14T12:01:02Z

please include a test workflow in the nano matrix

vlimant · 2024-05-14T12:01:52Z

enable nano

vlimant · 2024-05-14T12:08:37Z

our initial comment in #44817 about having Run3_post2023 instead of Run3_2024 and Run3_2025 was to simplify things and limit the number of modifiers. if @cms-sw/orp-l2 and others feel otherwise, we might roll back to Run3_2024 and Run3_2025

vlimant · 2024-05-21T15:09:44Z

@patinkaew : please go ahead and modify back to Run3_2024 and we will also need a dedicated "scenario" (similar to https://github.com/cms-sw/cmssw/blob/master/Configuration/DataProcessing/python/Impl/ppEra_Run3_2023.py) to be able to run this at Tier0 ; I'm rusty with how to implement this exactly ...

mmusich · 2024-05-22T08:17:47Z

lease go ahead and modify back to Run3_2024 and we will also need a dedicated "scenario"

This is what was already done in #43761 (now amended to comply with PPD prescription). This PR could simply piggy-back on that one (once merged).

patinkaew · 2024-05-24T22:34:11Z

Thanks. I'm waiting for #43761 to get merged and then I will make changes accordingly.

mmusich · 2024-06-12T07:30:07Z

Thanks. I'm waiting for #43761 to get merged and then I will make changes accordingly.

@patinkaew, #43761 is now merged.

patinkaew · 2024-06-12T22:46:45Z

@vlimant, I rebased to latest IB release (CMSSW_14_1_X_2024-06-12-1900) with #43761 merged and changed from Era_Run3_post2023 to use Era_Run3_2024.

I re-validated this change with

cmsDriver.py step2 -s NANO:@Scout --process NANO \
--data --eventcontent NANOAOD --datatier NANOAOD -n 10000 \
--era Run3_2024 --conditions auto:run3_data --filein fileIN.root

and the output NanoAOD file looks good.

cmsbuild · 2024-06-12T22:48:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44970/40563

This PR adds an extra 20KB to repository
Found files with invalid states:
- Configuration/Eras/python/Era_Run3_post2023_cff.py:
  - Added: 8e6f905
  - Deleted: c71b006

cmsbuild · 2024-06-12T22:48:35Z

Pull request #44970 was updated. @hqucms, @fabiocos, @rappoccio, @antoniovilela, @ftorrresd, @davidlange6, @vlimant, @cmsbuild can you please check and sign again.

vlimant · 2024-06-13T05:55:46Z

thanks. next step is to add the nano in the scouting scenario for that era. @drkovalskyi ; what is the scenario currently being run on the scouting dataset, if any ?

hqucms · 2024-07-25T20:24:29Z

ping again.
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 @cms-sw/operations-l2

srimanob · 2024-07-25T21:13:45Z

+Upgrade

AdrianoDee · 2024-07-26T08:33:59Z

+pdmv

vlimant · 2024-07-29T07:58:18Z

please test

cmsbuild · 2024-07-29T11:07:51Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91e61c/40660/summary.html
COMMIT: bf4bc36
CMSSW: CMSSW_14_1_X_2024-07-28-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44970/40660/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3423961
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3423935
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 196 log files, 165 edm output root files, 45 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 1065 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 21
DQMHistoTests: Total histograms compared: 54901
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 54901
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
Checked 100 log files, 57 edm output root files, 21 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Nano ERROR: Missing ref/2500.237-size.json
Nano ERROR: Missing ref/2500.237-size.json
| Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
| --- | --- | --- | --- | --- | --- | --- | --- | --- |
| 2500.001 | 2.783 | 2.783 | 0.000 ( +0.0% ) | 3.35 | 3.34 | +0.3% | 6.028 | 5.972 |
| 2500.002 | 2.897 | 2.897 | 0.000 ( +0.0% ) | 2.97 | 2.93 | +1.4% | 6.416 | 6.307 |
| 2500.003 | 2.843 | 2.843 | 0.000 ( +0.0% ) | 3.10 | 3.08 | +0.7% | 6.360 | 6.272 |
| 2500.011 | 1.446 | 1.446 | 0.000 ( +0.0% ) | 5.78 | 5.75 | +0.6% | 2.401 | 2.306 |
| 2500.012 | 1.906 | 1.906 | 0.000 ( +0.0% ) | 3.19 | 3.13 | +1.8% | 2.587 | 2.448 |
| 2500.013 | 1.761 | 1.761 | 0.000 ( +0.0% ) | 4.58 | 4.49 | +2.1% | 2.492 | 2.366 |
| 2500.021 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 0.97 | 0.98 | -0.8% | 2.199 | 2.162 |
| 2500.022 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 0.95 | 0.95 | +0.6% | 2.207 | 2.164 |
| 2500.023 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 0.95 | 0.96 | -0.7% | 2.151 | 2.115 |
| 2500.024 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 0.70 | 0.72 | -2.3% | 2.314 | 2.279 |
| 2500.031 | 0.035 | 0.035 | 0.000 ( +0.0% ) | 0.88 | 0.90 | -2.4% | 2.304 | 2.255 |
| 2500.032 | 0.036 | 0.036 | 0.000 ( +0.0% ) | 0.90 | 0.90 | +0.5% | 2.246 | 2.199 |
| 2500.033 | 0.037 | 0.037 | 0.000 ( +0.0% ) | 0.80 | 0.81 | -1.5% | 2.351 | 2.300 |
| 2500.034 | 0.036 | 0.036 | 0.000 ( +0.0% ) | 0.81 | 0.79 | +2.8% | 2.332 | 2.280 |
| 2500.101 | 2.642 | 2.642 | 0.000 ( +0.0% ) | 8.95 | 8.91 | +0.5% | 6.260 | 6.268 |
| 2500.111 | 1.327 | 1.327 | 0.000 ( +0.0% ) | 20.37 | 19.81 | +2.8% | 2.225 | 2.099 |
| 2500.112 | 1.731 | 1.731 | 0.000 ( +0.0% ) | 15.04 | 15.18 | -0.9% | 2.110 | 2.072 |
| 2500.131 | 5.194 | 5.194 | 0.000 ( +0.0% ) | 15.72 | 15.79 | -0.4% | 1.542 | 1.424 |
| 2500.201 | 2.475 | 2.475 | 0.000 ( +0.0% ) | 7.46 | 7.35 | +1.5% | 5.528 | 5.463 |
| 2500.211 | 1.589 | 1.589 | 0.000 ( +0.0% ) | 17.31 | 17.40 | -0.5% | 2.098 | 2.035 |
| 2500.212 | 2.030 | 2.030 | 0.000 ( +0.0% ) | 13.61 | 13.74 | -0.9% | 2.144 | 2.096 |
| 2500.221 | 2.006 | 2.006 | 0.000 ( +0.0% ) | 7.73 | 7.69 | +0.6% | 2.269 | 2.224 |
| 2500.222 | 3.071 | 3.071 | 0.000 ( +0.0% ) | 7.54 | 7.33 | +2.8% | 2.325 | 2.284 |
| 2500.223 | 8.884 | 8.884 | 0.000 ( +0.0% ) | 2.79 | 2.79 | -0.3% | 2.309 | 2.001 |
| 2500.224 | 5.511 | 5.511 | 0.000 ( +0.0% ) | 1.10 | 1.10 | -0.2% | 2.011 | 1.876 |
| 2500.225 | 5.530 | 5.530 | 0.000 ( +0.0% ) | 1.02 | 1.00 | +1.3% | 2.001 | 1.968 |
| 2500.226 | 2.970 | 2.970 | 0.000 ( +0.0% ) | 7.59 | 7.40 | +2.5% | 2.285 | 2.275 |
| 2500.227 | 8.972 | 8.972 | 0.000 ( +0.0% ) | 10.23 | 10.05 | +1.9% | 1.391 | 1.119 |
| 2500.231 | 1.407 | 1.407 | 0.000 ( +0.0% ) | 13.48 | 13.61 | -1.0% | 1.949 | 1.932 |
| 2500.232 | 2.145 | 2.145 | 0.000 ( +0.0% ) | 13.44 | 13.70 | -1.9% | 1.727 | 1.998 |
| 2500.233 | 4.667 | 4.667 | 0.000 ( +0.0% ) | 4.86 | 4.80 | +1.4% | 1.740 | 2.010 |
| 2500.234 | 3.304 | 3.304 | 0.000 ( +0.0% ) | 1.49 | 1.48 | +1.0% | 1.721 | 2.043 |
| 2500.235 | 3.314 | 3.314 | 0.000 ( +0.0% ) | 1.40 | 1.40 | -0.4% | 2.085 | 2.067 |
| 2500.236 | 2.082 | 2.082 | 0.000 ( +0.0% ) | 13.39 | 13.48 | -0.7% | 2.020 | 2.015 |
| 2500.241 | 9.405 | 9.405 | 0.000 ( +0.0% ) | 3.01 | 3.22 | -6.7% | 1.761 | 1.884 |
| 2500.242 | 10.331 | 10.331 | 0.000 ( +0.0% ) | 0.88 | 0.88 | +0.5% | 1.697 | 1.647 |
| 2500.243 | 2.712 | 2.712 | 0.000 ( +0.0% ) | 8.36 | 8.22 | +1.8% | 1.062 | 1.068 |
| 2500.244 | 485.976 | 485.976 | 0.000 ( +0.0% ) | 0.57 | 0.57 | +0.6% | 1.610 | 1.581 |
| 2500.245 | 823.158 | 823.158 | 0.000 ( +0.0% ) | 0.75 | 0.76 | -1.0% | 1.546 | 1.565 |
| 2500.901 | 1.749 | 1.749 | 0.000 ( +0.0% ) | 21.79 | 20.48 | +6.4% | 1.796 | 1.766 |
| 2500.902 | 1.598 | 1.598 | 0.000 ( +0.0% ) | 22.48 | 21.82 | +3.0% | 1.763 | 1.692 |
| 2500.911 | 13.931 | 13.931 | 0.000 ( +0.0% ) | 3.17 | 1.70 | +86.6% | 1.074 | 1.042 |
| 2500.912 | 0.310 | 0.171 | 0.139 ( +81.2% ) | 1.16 | 0.84 | +37.5% | 0.965 | 0.946 |
| 2500.913 | 0.110 | 0.110 | 0.000 ( +0.0% ) | 1.20 | 1.17 | +2.6% | 0.968 | 0.953 |

mmusich · 2024-07-29T12:24:01Z

@mandrenguyen do you think we can get this by having ORP signing for operations? (TSG / Scouting request @kelmorab @elfontan ).

mandrenguyen · 2024-07-29T12:28:15Z

+1

cmsbuild · 2024-07-29T12:28:42Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_14_1_X milestone May 14, 2024

cmsbuild added operations-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels May 14, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 14, 2024

vlimant reviewed May 14, 2024

View reviewed changes

mmusich mentioned this pull request May 22, 2024

add Era_Run3_2024, Era_Run3_2025, Tier0 reco scenario for 2024, and change default era in PyReleaseValidation #43761

Merged

patinkaew force-pushed the scouting_nano_test_14_1_X_2024-05-13-2300 branch from 8e75a28 to c71b006 Compare June 12, 2024 22:37

cmsbuild added code-checks-pending and removed code-checks-approved labels Jun 12, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 12, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 25, 2024

cmsbuild added pdmv-approved and removed pdmv-pending labels Jul 26, 2024

cmsbuild added tests-started and removed tests-approved tests-ib-failure labels Jul 29, 2024

cmsbuild added tests-approved and removed tests-started labels Jul 29, 2024

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Jul 29, 2024

cmsbuild merged commit 5ef98be into cms-sw:master Jul 29, 2024
13 checks passed

cmsbuild mentioned this pull request Aug 2, 2024

Fix bazel recipe cms-sw/cmsdist#9336

Merged

patinkaew mentioned this pull request Aug 28, 2024

Change ScoutingNano event content #45820

Merged

missirol mentioned this pull request Sep 1, 2024

rename modifier run3_2024_L1T to stage2L1Trigger_2024 [14_0_X] #45850

Merged

This was referenced Sep 7, 2024

[14_1_X] Backport of #45820: Change ScoutingNano event content #45949

Merged

[14_0_X] Backport of 44970 and 45820 (ScoutingNano event content changes for 2024 and T0 scenario for HLTSCOUT datatier) #45950

Merged

silviodonato mentioned this pull request Sep 9, 2024

NanoScouting in Prompt dmwm/T0#4991

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ScoutingMuonNoVtx and ScoutingMuonVtx in Run3Scouting Nano starting from 2024 data taking #44970

Add ScoutingMuonNoVtx and ScoutingMuonVtx in Run3Scouting Nano starting from 2024 data taking #44970

patinkaew commented May 14, 2024

cmsbuild commented May 14, 2024 •

edited

Loading

cmsbuild commented May 14, 2024

cmsbuild commented May 14, 2024

vlimant May 14, 2024

patinkaew May 14, 2024

vlimant commented May 14, 2024

vlimant commented May 14, 2024

vlimant commented May 14, 2024

vlimant commented May 21, 2024

mmusich commented May 22, 2024

patinkaew commented May 24, 2024

mmusich commented Jun 12, 2024

patinkaew commented Jun 12, 2024 •

edited

Loading

cmsbuild commented Jun 12, 2024

cmsbuild commented Jun 12, 2024

vlimant commented Jun 13, 2024

hqucms commented Jul 25, 2024

srimanob commented Jul 25, 2024

AdrianoDee commented Jul 26, 2024

vlimant commented Jul 29, 2024

cmsbuild commented Jul 29, 2024

mmusich commented Jul 29, 2024 •

edited

Loading

mandrenguyen commented Jul 29, 2024

cmsbuild commented Jul 29, 2024

		@@ -0,0 +1,3 @@
		import FWCore.ParameterSet.Config as cms

		run3_scouting_nanoAOD_post2023 = cms.Modifier()

Add ScoutingMuonNoVtx and ScoutingMuonVtx in Run3Scouting Nano starting from 2024 data taking #44970

Add ScoutingMuonNoVtx and ScoutingMuonVtx in Run3Scouting Nano starting from 2024 data taking #44970

Conversation

patinkaew commented May 14, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented May 14, 2024 • edited Loading

cmsbuild commented May 14, 2024

cmsbuild commented May 14, 2024

vlimant May 14, 2024

Choose a reason for hiding this comment

patinkaew May 14, 2024

Choose a reason for hiding this comment

vlimant commented May 14, 2024

vlimant commented May 14, 2024

vlimant commented May 14, 2024

vlimant commented May 21, 2024

mmusich commented May 22, 2024

patinkaew commented May 24, 2024

mmusich commented Jun 12, 2024

patinkaew commented Jun 12, 2024 • edited Loading

cmsbuild commented Jun 12, 2024

cmsbuild commented Jun 12, 2024

vlimant commented Jun 13, 2024

hqucms commented Jul 25, 2024

srimanob commented Jul 25, 2024

AdrianoDee commented Jul 26, 2024

vlimant commented Jul 29, 2024

cmsbuild commented Jul 29, 2024

Comparison Summary

NANO Comparison Summary

mmusich commented Jul 29, 2024 • edited Loading

mandrenguyen commented Jul 29, 2024

cmsbuild commented Jul 29, 2024

cmsbuild commented May 14, 2024 •

edited

Loading

patinkaew commented Jun 12, 2024 •

edited

Loading

mmusich commented Jul 29, 2024 •

edited

Loading