Change ScoutingNano event content #45820
Conversation
…ts particleNet branch, fix incorrect orders of particleNet tags for reclustered ak8 jets, rename ScoutingTrack__lambda to ScoutingTrack_lambda_
…icleScoutingTable), drop scouting tracks, add scouting PFJet (clustered at HLT)
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45820/41558 |
|
A new Pull Request was created by @patinkaew for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable nano |
|
please test |
| @@ -141,7 +141,7 @@ | |||
| nValidStripHits = Var('tk_nValidStripHits', 'int', doc='number of valid strip hits'), | |||
| nTrackerLayersWithMeasurement = Var('tk_nTrackerLayersWithMeasurement', 'int', doc='number of tracker layers with measurements'), | |||
| qoverp = Var('tk_qoverp', 'float', precision=10, doc='qoverp'), | |||
| _lambda = Var('tk_lambda', 'float', precision=10, doc='lambda'), | |||
| lambda_ = Var('tk_lambda', 'float', precision=10, doc='lambda'), | |||
There was a problem hiding this comment.
why keeping the trailing underscore at all ?
There was a problem hiding this comment.
lambda is a keyword in python and I believe that was the reason initially to call it _lambda.
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
| cut = cms.string(""), | ||
| doc = cms.string("ScoutingJet"), | ||
| doc = cms.string("ak4 jets from re-clustering scouting PF candidates with CHS applied"), |
There was a problem hiding this comment.
Where is CHS applied to ak4ScoutingJets and ak8ScoutingJets? I see in
CHS is set to false.
There was a problem hiding this comment.
Thank you for catching this! There seems to be mismatch (whether CHS is applied or not) in private and cmssw code. I will rename them to PFJets.
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45820/41578 |
|
Pull request #45820 was updated. @cmsbuild, @ftorrresd, @hqucms, @vlimant can you please check and sign again. |
|
please test |
|
-1 Failed Tests: RelVals-NANO RelVals-NANO
Comparison SummarySummary:
|
|
Hi @hqucms, Thank you for rerunning the tests! Checking the log files of failed tests, I think they are all because MINIAOD input files cannot be open.
Checking DAS, the MINIAOD file seems to be on disk, so it was probably a temporary problem when tests were run. |
|
@smuzaffar It seems that this file disappeared? |
|
@hqucms , |
|
by the way, I have restarted the nano relval tests |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
NANO Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
Nano size comparison Summary:
|
Thanks a lot @smuzaffar ! |
|
+1 |
cmsbuild
added
fully-signed
xpog-approved
and removed
pending-signatures
xpog-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
[14_1_X] Backport of #45820: Change ScoutingNano event content
PR description:
This PR changes the event content of ScoutingNano to address the following points:
patTriggerScoutingstep in producing TrigObj table causes very noisy log (trigger::TriggerEvent product with InputTag 'hltTriggerSummaryAOD::HLT' not in eventfor every event). This issue was raised by O&C (Add ScoutingMuonNoVtx and ScoutingMuonVtx in Run3Scouting Nano starting from 2024 data taking #44970 (comment)). This is caused by missinghltTriggerSummaryAOD::HLTin ScoutingPFRun3 RAW/HLTSCOUT samples._lambdatolambda_forScoutingTrackcollection so the output branch name isScoutingTrack_lambda_instead ofScouting__lambdain root file.PR validation:
Event sizes are measured with relval_nano matrix for ScoutingNano:
For full size reports, please refer to [1].
In addition, this PR pass all standard unit tests
scram b runtestsand pass all tests from running
runTheMatrix.py -l limited -i all --ibeosIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport, but backport to 14_0_X (together with #44970) will follow.
FYI: @silviodonato @elfontan @karim
[1] https://indico.cern.ch/event/1441452/#preview:5119073