Alpaka Pixel: Write nTracks=0 When No Track Stored

[AdrianoDee]

PR description:

This PR proposes a small fix in order to avoid the loop on the track SoA done by vertexFinder when no track is actually stored.

solves #45871

PR validation:

runTheMatrix.py -w upgrade -l 12461.402 does not crash.

[AdrianoDee]

type bug-fix

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45876/41630

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45876/41630/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45876/41630/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45876/41631

[cmsbuild]

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

• RecoTracker/PixelSeeding (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[AdrianoDee]

enable gpu

[AdrianoDee]

test parameters:

• workflow_opts = -w upgrade
• workflows_gpu = 12461.402, 12861.0, 12851.402
• workflows = 12461.402, 12861.0, 12851.402

[AdrianoDee]

please test

[AdrianoDee]

please test

[cmsbuild]

-1

Failed Tests: RelVals-GPU
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5c629/41297/summary.html
COMMIT: fcc2c51
CMSSW: CMSSW_14_2_X_2024-09-04-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45876/41297/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-GPU

ValueError: Undefined workflows: 12861.0, 12861.402

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 77 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3633830
• DQMHistoTests: Total failures: 4592
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3629218
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 210 log files, 183 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[AdrianoDee]

test parameters:

• workflow_opts = -w upgrade
• workflows_gpu = 12461.402, 12861.0, 12861.402
• workflows = 12461.402, 12861.0, 12861.402
• workflow_opts_gpu = -w upgrade

[AdrianoDee]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5c629/41305/summary.html
COMMIT: fcc2c51
CMSSW: CMSSW_14_2_X_2024-09-04-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45876/41305/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3633830
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3633804
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 210 log files, 183 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 6
• DQMHistoTests: Total histograms compared: 37044
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 37026
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
• Checked 20 log files, 25 edm output root files, 6 DQM output files
• TriggerResults: no differences found

[AdrianoDee]

urgent

• backport(s) needed for datataking

[antoniovilela]

ping @cms-sw/reconstruction-l2
Thanks.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1