[Testing] Update ROOT and Cling to LLVM18 #209

aandvalenzuela · 2024-08-27T13:43:41Z

Testing ROOT llvm18 update as requested in root-project#15696 (comment)

aandvalenzuela · 2024-08-27T13:47:28Z

please test for CMSSW_14_1_ROOT6_X

We moved today release cycle to 14_2_X, so the first IB for it will be available tonight

cmsbuild · 2024-08-27T13:48:49Z

This PR touches too many files (6364 >= 3001) and will not be processed.
Please ensure you have selected the correct target branch and consider splitting this PR into several.
The processing of this PR will resume once the number of changed files drops below the limit.

dpiparo · 2024-08-27T13:53:03Z

😱

aandvalenzuela · 2024-08-27T14:37:41Z

FYI, cms-sw/cms-bot#2323 disables the check on the number of files in non-cmssw repositories, so that we can move forward with the testing

cmsbuild · 2024-08-28T05:33:09Z

A new Pull Request was created by @aandvalenzuela for branch cms/master/9e38588b80.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @missirol, @mmusich, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2024-08-28T05:33:09Z

cms-bot internal usage

aandvalenzuela · 2024-08-28T05:33:48Z

please test for CMSSW_14_2_ROOT6_X

cmsbuild · 2024-08-28T13:43:45Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2e919/41168/summary.html
COMMIT: b9b6290
CMSSW: CMSSW_14_2_ROOT6_X_2024-08-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/209/41168/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 14 lines to the logs
Reco comparison results: 1276 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3328202
DQMHistoTests: Total failures: 6390
DQMHistoTests: Total nulls: 8
DQMHistoTests: Total successes: 3321784
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.2720000000000002 KiB( 43 files compared)
DQMHistoSizes: changed ( 10224.0,... ): -0.004 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 10224.0,... ): -0.004 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 25.0,... ): -0.008 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 25.0,... ): -0.008 KiB MessageLogger/Warnings
Checked 191 log files, 161 edm output root files, 44 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-08-28T17:08:15Z

Pull request #209 was updated.

cmsbuild · 2024-08-28T17:08:16Z

cms-bot internal usage

aandvalenzuela · 2024-08-28T22:21:08Z

please test for CMSSW_14_2_ROOT6_X

cmsbuild · 2024-08-29T07:36:16Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2e919/41185/summary.html
COMMIT: 6456e70
CMSSW: CMSSW_14_2_ROOT6_X_2024-08-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/209/41185/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 9 lines to the logs
Reco comparison results: 1268 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3328202
DQMHistoTests: Total failures: 6384
DQMHistoTests: Total nulls: 10
DQMHistoTests: Total successes: 3321788
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.2720000000000002 KiB( 43 files compared)
DQMHistoSizes: changed ( 10224.0,... ): -0.004 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 10224.0,... ): -0.004 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 25.0,... ): -0.008 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 25.0,... ): -0.008 KiB MessageLogger/Warnings
Checked 191 log files, 161 edm output root files, 44 DQM output files
TriggerResults: no differences found

iarspider · 2024-08-29T07:52:03Z

please test for CMSSW_14_2_ROOT6_X/el8_aarch64_gcc12

Matching the change in: - llvm/llvm-project#78463

- Include `StringExtras.h` This is now needed due to: llvm/llvm-project@3ff3af3

In LLVM 18 with incremental extensions enabled, the Preprocessor will never report tok::eof, but tok::annot_repl_input_end instead.

Prevents failures such as: ``` Processing roottest/root/meta/runnamespace.C... Error in cling::MetaProcessor: cannot read from binary input: 'runnamespace.C' ``` This is needed for macros that start with `{` after the rebase

C++20 builds were failing due to the commit: llvm-project/commit/574ee1c02ef73b66c5957cf93888234b0471695f with an error `imported non C++20 importable modules`

This makes them run after the <Platform> library: It provides the __cxa_atexit function, which must not be found in the process.

LLVM now defines multiple Dylibs, and __cxa_atexit is provided in the <Platform> library.

We started seeing an assertion failure in ~FinalizedAlloc when we moved the generators to ProcessSymbols JITDylib: [cling] Move generators to ProcessSymbols JITDylib This ikely changed the destruction order that caused the assertion to trigger.

This fixes the Cling test Driver/E.C.

This applies the upstream changes in commit llvm/llvm-project@9992b38 to a copy of the modulemap from MacOSX14.2.sdk.

This fixes the failing python enum tests like: - `roottest-python-cpp-cpp` - `roottest-python-cmdLineUtils-ROOT_8197` Also remove `R__BYTESWAP` which should not be needed anymore. The leak was fixed with: llvm/llvm-project#78311 This caused our tests to fail as they relied on the previous behavior.

Upstream LLVM now unconditionally uses indirect / PC relative personality encodings since commit llvm/llvm-project@ca65969 This leads to references of DW.ref.__gxx_personality_v0 that cannot be resolved with RuntimeDyld, that we are still using for the moment. As a fix, auto-claim symbols as we are doing for PPC, see upstream commit: llvm/llvm-project@72ea1a7

There are still failures with RuntimeDyld on AArch64 which seem to be solved with JITLink, so make the switch now.

cmsbuild · 2024-09-10T14:15:39Z

Pull request #209 was updated.

cmsbuild · 2024-09-10T14:15:41Z

cms-bot internal usage

cmsbuild added orp-pending pending-signatures externals-pending tests-started labels Aug 28, 2024

cmsbuild added tests-pending tests-started and removed tests-started tests-pending labels Aug 28, 2024

cmsbuild added tests-approved and removed tests-started labels Aug 28, 2024

devajithvs force-pushed the dev.llvm18 branch from b9b6290 to 6456e70 Compare August 28, 2024 17:02

cmsbuild added tests-pending and removed tests-approved labels Aug 28, 2024

cmsbuild added tests-started and removed tests-pending labels Aug 28, 2024

cmsbuild added tests-approved and removed tests-started labels Aug 29, 2024

devajithvs and others added 24 commits September 10, 2024 16:07

[core] Use isPureVirtual

f656008

Matching the change in: - llvm/llvm-project#78463

[core] Additional parameters in AnnotateAttr::CreateImplicit

6ff579f

[core] Include missing headers

97244c0

- Include `StringExtras.h` This is now needed due to: llvm/llvm-project@3ff3af3

[core] Rename enums to match upstream LLVM 18

57468c8

[interpreter] Bump LLVM version

bcac194

[TCling] Handle enumeration value ‘StructuralValue’

6dbb74f

[cling] Adapt tok::eof -> tok::annot_repl_input_end

a3c84ee

In LLVM 18 with incremental extensions enabled, the Preprocessor will never report tok::eof, but tok::annot_repl_input_end instead.

[cling] Disable line numbers in error messages and warnings

fb5505c

[metcling] Povide a transaction before using GetDecl()

37cb102

[cling] Do not report an error if the fileType is a tapi_file

fc2002f

Prevents failures such as: ``` Processing roottest/root/meta/runnamespace.C... Error in cling::MetaProcessor: cannot read from binary input: 'runnamespace.C' ``` This is needed for macros that start with `{` after the rebase

[cling] Set BuiltinHeadersInSystemModules = 1

c28b205

[cling] Fix C++20 builds

8962e22

C++20 builds were failing due to the commit: llvm-project/commit/574ee1c02ef73b66c5957cf93888234b0471695f with an error `imported non C++20 importable modules`

[cling] Move generators to ProcessSymbols JITDylib

3eb76a4

This makes them run after the <Platform> library: It provides the __cxa_atexit function, which must not be found in the process.

[cling] Replace symbols in platform Dylib

6ab0c92

LLVM now defines multiple Dylibs, and __cxa_atexit is provided in the <Platform> library.

Make parallel jobs 4 for Windows

9d2327b

[cling] Enable conforming preprocessor with MSVC

70a1cdb

[cling] Fix option parsing, again

4950e9f

This fixes the Cling test Driver/E.C.

[cling] Update expected output of cling/test/Lookup/data.C

bdd8080

[runtime_cxxmodules] Fix macOS 13 modulemap for LLVM 18

6055bab

This applies the upstream changes in commit llvm/llvm-project@9992b38 to a copy of the modulemap from MacOSX14.2.sdk.

[core] Fix ASan build with LLVM 18

bc96e54

[cling] Enable JITLink by default for AArch64 on Linux

a52d34d

There are still failures with RuntimeDyld on AArch64 which seem to be solved with JITLink, so make the switch now.

devajithvs force-pushed the dev.llvm18 branch from 3873f4d to a52d34d Compare September 10, 2024 14:09

cmsbuild added tests-pending and removed tests-rejected labels Sep 10, 2024

smuzaffar closed this Sep 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Testing] Update ROOT and Cling to LLVM18 #209

[Testing] Update ROOT and Cling to LLVM18 #209

aandvalenzuela commented Aug 27, 2024

aandvalenzuela commented Aug 27, 2024

cmsbuild commented Aug 27, 2024

dpiparo commented Aug 27, 2024

aandvalenzuela commented Aug 27, 2024

cmsbuild commented Aug 28, 2024

cmsbuild commented Aug 28, 2024 •

edited

Loading

aandvalenzuela commented Aug 28, 2024

cmsbuild commented Aug 28, 2024

cmsbuild commented Aug 28, 2024

cmsbuild commented Aug 28, 2024 •

edited

Loading

aandvalenzuela commented Aug 28, 2024

cmsbuild commented Aug 29, 2024

iarspider commented Aug 29, 2024

cmsbuild commented Sep 10, 2024

cmsbuild commented Sep 10, 2024

[Testing] Update ROOT and Cling to LLVM18 #209

[Testing] Update ROOT and Cling to LLVM18 #209

Conversation

aandvalenzuela commented Aug 27, 2024

aandvalenzuela commented Aug 27, 2024

cmsbuild commented Aug 27, 2024

dpiparo commented Aug 27, 2024

aandvalenzuela commented Aug 27, 2024

cmsbuild commented Aug 28, 2024

cmsbuild commented Aug 28, 2024 • edited Loading

aandvalenzuela commented Aug 28, 2024

cmsbuild commented Aug 28, 2024

Comparison Summary

cmsbuild commented Aug 28, 2024

cmsbuild commented Aug 28, 2024 • edited Loading

aandvalenzuela commented Aug 28, 2024

cmsbuild commented Aug 29, 2024

Comparison Summary

iarspider commented Aug 29, 2024

cmsbuild commented Sep 10, 2024

cmsbuild commented Sep 10, 2024

cmsbuild commented Aug 28, 2024 •

edited

Loading

cmsbuild commented Aug 28, 2024 •

edited

Loading