Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Alpaka Pixel: Write nTracks=0 When No Track Stored #45877

Merged

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented Sep 4, 2024

PR description:

Plain backport of #45876 to 14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

A new Pull Request was created by @AdrianoDee for CMSSW_14_0_X.

It involves the following packages:

  • RecoTracker/PixelSeeding (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

cms-bot internal usage

@AdrianoDee
Copy link
Contributor Author

type bug-fix

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • workflow_opts = -w upgrade
  • workflows_gpu = 12461.402, 12861.0, 12851.402
  • workflows = 12461.402, 12861.0, 12851.402

@AdrianoDee AdrianoDee force-pushed the fix_zero_tracks_alpaka_140 branch 2 times, most recently from 1572473 to d4ceaa8 Compare September 4, 2024 14:59
@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

This PR contains too many commits (3381 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

@AdrianoDee
Copy link
Contributor Author

backport of #45876

@AdrianoDee
Copy link
Contributor Author

please abort

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • workflow_opts = -w upgrade
  • workflows_gpu = 12461.402, 12861.0, 12861.402
  • workflows = 12461.402, 12861.0, 12861.402

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b596e6/41296/summary.html
COMMIT: d4ceaa8
CMSSW: CMSSW_14_0_X_2024-09-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45877/41296/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b596e6/41296/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b596e6/41296/git-merge-result

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor Author

urgent

  • backport(s) needed for datataking

@cmsbuild cmsbuild added the urgent label Sep 5, 2024
@antoniovilela
Copy link
Contributor

ping @cms-sw/reconstruction-l2

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b1d8deb into cms-sw:CMSSW_14_0_X Sep 6, 2024
10 checks passed
@AdrianoDee AdrianoDee deleted the fix_zero_tracks_alpaka_140 branch September 6, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants