Implement a workaround for `-Warray-bounds` in LTO builds #45455

fwyzard · 2024-07-15T10:28:23Z

PR description:

Implement a workaround for -Warray-bounds in LTO builds.

PR validation:

None.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport foreseen.

cmsbuild · 2024-07-15T10:28:47Z

cms-bot internal usage

fwyzard · 2024-07-15T10:28:48Z

please test with cms-sw/cmsdist#9301

fwyzard · 2024-07-15T10:29:18Z

please test with cms-sw/cmsdist#9301 for el9_amd64_gcc13

cmsbuild · 2024-07-15T10:29:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45455/40911

cmsbuild · 2024-07-15T10:30:11Z

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

HeterogeneousCore/AlpakaInterface (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2024-07-15T10:57:14Z

@fwyzard , this will not work as HeterogeneousCore/AlpakaInterface does not generate alpaka backend. This change should go in to RecoTracker/PixelSeeding/plugins/BuildFile.xml . Also look like this is a <use name="dep" for="something"/> is a private.local dependency only (https://github.com/cms-sw/cmssw-config/blob/scramv3/SCRAM/Plugins/BuildRules.py#L1427-L1430 ) so it will not not be exported. For now, I would suggest to add it in RecoTracker/PixelSeeding/plugins/BuildFile.xml . I will update scram and build rules so that one can make such dependencies public so that dependent packages can also get it

fwyzard · 2024-07-15T11:53:03Z

Mhm, I see.

So at the moment the behaviour is just like adding the flags by hand in RecoTracker/PixelSeeding/plugins/BuildFile.xml ?

fwyzard · 2024-07-15T12:30:07Z

please test with cms-sw/cmsdist#9301

fwyzard · 2024-07-15T12:30:17Z

please test with cms-sw/cmsdist#9301 for el9_amd64_gcc13

cmsbuild · 2024-07-15T12:32:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45455/40916

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTracker/PixelSeeding/plugins/BuildFile.xml modified in PR(s): [GCC13] Suppress array-bound error #45179 from PixelSeeding #45340

cmsbuild · 2024-07-16T06:51:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0625ac/40397/summary.html
COMMIT: 216b4df
CMSSW: CMSSW_14_1_X_2024-07-12-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45455/40397/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 14744 lines to the logs
Reco comparison results: 61325 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3451616
DQMHistoTests: Total failures: 359212
DQMHistoTests: Total nulls: 228
DQMHistoTests: Total successes: 3092156
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1.1780000000000002 KiB( 48 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.063 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): 0.799 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): -0.112 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.064 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -1.600 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 8.0 ): -0.262 KiB SiStrip/MechanicalView
Checked 206 log files, 170 edm output root files, 49 DQM output files

smuzaffar · 2024-07-16T13:28:12Z

please test for CMSSW_14_1_CLANG_X

smuzaffar · 2024-07-16T14:09:00Z

@cms-sw/reconstruction-l2 , can you please review this? Change here is identical to #45340 which you already had approved. This should fix the warnings for 14.1.X gcc 13 and build errors for CLANG IBs

cmsbuild · 2024-07-16T14:15:29Z

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0625ac/40431/summary.html
COMMIT: 216b4df
CMSSW: CMSSW_14_1_CLANG_X_2024-07-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45455/40431/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test test_MC_23_setup had ERRORS
---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_22_crosscheck had ERRORS
and more ...

RelVals

5.15.1_TTbarFS/step1_TTbarFS.log
135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log

Expand to see more relval errors ...

AddOn Tests

fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 13 sec (ended on Tue Jul 16 16:09:39 2024) - exit: 256

fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 9 sec (ended on Tue Jul 16 16:09:39 2024) - exit: 256

fastsim2

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 8 sec (ended on Tue Jul 16 16:09:39 2024) - exit: 256

Expand to see more addon errors ...

smuzaffar · 2024-07-16T14:23:42Z

please ignore #45455 (comment) errors, these are due to broken CLANG IB

mandrenguyen · 2024-07-16T16:54:42Z

+reconstruction
Errors are to be ignored:
#45455 (comment)

cmsbuild · 2024-07-16T16:55:04Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2024-07-17T09:51:52Z

@cms-sw/orp-l2 , this fixes warnings for gcc12 and build errors for gcc13. Can you please review and approve this?

rappoccio · 2024-07-17T13:07:37Z

+1

rappoccio · 2024-07-17T13:07:44Z

merge

cmsbuild added this to the CMSSW_14_1_X milestone Jul 15, 2024

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending heterogeneous-pending labels Jul 15, 2024

cmsbuild added tests-started requires-external and removed tests-pending labels Jul 15, 2024

fwyzard mentioned this pull request Jul 15, 2024

[GCC13] Suppress array-bound error #45179 from PixelSeeding #45340

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 15, 2024

Implement a workaround for -Warray-bounds in LTO builds

216b4df

fwyzard force-pushed the no-array-bounds-flags branch from 4b59ff4 to 216b4df Compare July 15, 2024 12:29

cmsbuild added reconstruction-pending code-checks-pending tracking and removed code-checks-approved heterogeneous-pending labels Jul 15, 2024

cmsbuild removed the code-checks-pending label Jul 15, 2024

smuzaffar mentioned this pull request Jul 15, 2024

Add a tool to disable the -Warray-bounds flag cms-sw/cmsdist#9301

Merged

cmsbuild added tests-approved and removed tests-started labels Jul 16, 2024

cmsbuild added tests-started and removed requires-external tests-approved labels Jul 16, 2024

cmsbuild added tests-rejected and removed tests-started labels Jul 16, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Jul 16, 2024

cmsbuild added orp-approved and removed orp-pending labels Jul 17, 2024

cmsbuild merged commit f9f989b into cms-sw:master Jul 17, 2024
13 of 16 checks passed

cmsbuild mentioned this pull request Jul 17, 2024

Alpaka Pixel: Reading layerStart at Runtime and Variable thePitch* #45421

Merged

fwyzard deleted the no-array-bounds-flags branch July 17, 2024 14:43

cmsbuild mentioned this pull request Jul 17, 2024

Update GCC 12.4.1 cms-sw/cmsdist#9303

Open

makortel mentioned this pull request Jul 19, 2024

Added TestSourceProcessor helper #45443

Merged

slava77 mentioned this pull request Jul 27, 2024

RecoTracker/PixelSeeding: array subscript ... is above array bounds in Alpaka/FlexiStorage #45179

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement a workaround for `-Warray-bounds` in LTO builds #45455

Implement a workaround for `-Warray-bounds` in LTO builds #45455

fwyzard commented Jul 15, 2024

cmsbuild commented Jul 15, 2024 •

edited

Loading

fwyzard commented Jul 15, 2024

fwyzard commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

smuzaffar commented Jul 15, 2024 •

edited

Loading

fwyzard commented Jul 15, 2024

fwyzard commented Jul 15, 2024

fwyzard commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 16, 2024

smuzaffar commented Jul 16, 2024

smuzaffar commented Jul 16, 2024 •

edited

Loading

cmsbuild commented Jul 16, 2024

smuzaffar commented Jul 16, 2024

mandrenguyen commented Jul 16, 2024

cmsbuild commented Jul 16, 2024

smuzaffar commented Jul 17, 2024

rappoccio commented Jul 17, 2024

rappoccio commented Jul 17, 2024

Implement a workaround for -Warray-bounds in LTO builds #45455

Implement a workaround for -Warray-bounds in LTO builds #45455

Conversation

fwyzard commented Jul 15, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jul 15, 2024 • edited Loading

fwyzard commented Jul 15, 2024

fwyzard commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

smuzaffar commented Jul 15, 2024 • edited Loading

fwyzard commented Jul 15, 2024

fwyzard commented Jul 15, 2024

fwyzard commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 16, 2024

Comparison Summary

smuzaffar commented Jul 16, 2024

smuzaffar commented Jul 16, 2024 • edited Loading

cmsbuild commented Jul 16, 2024

Unit Tests

RelVals

AddOn Tests

smuzaffar commented Jul 16, 2024

mandrenguyen commented Jul 16, 2024

cmsbuild commented Jul 16, 2024

smuzaffar commented Jul 17, 2024

rappoccio commented Jul 17, 2024

rappoccio commented Jul 17, 2024

Implement a workaround for `-Warray-bounds` in LTO builds #45455

Implement a workaround for `-Warray-bounds` in LTO builds #45455

cmsbuild commented Jul 15, 2024 •

edited

Loading

smuzaffar commented Jul 15, 2024 •

edited

Loading

smuzaffar commented Jul 16, 2024 •

edited

Loading