Added TestSourceProcessor helper

[Dr15Jones]

PR description:

Added TestSourceProcessor which is similar to TestProcessor but is specialized for testing Sources.

PR validation:

Code compiles and new unit tests pass.

[Dr15Jones]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45443/40893

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• FWCore/TestProcessor (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7a52e/40366/summary.html
COMMIT: 078d2cb
CMSSW: CMSSW_14_1_X_2024-07-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45443/40366/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testFWCoreTestProcessor had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 13 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3246798
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246778
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 199 log files, 163 edm output root files, 47 DQM output files
• TriggerResults: no differences found

[makortel]

Unit test failure looks related

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45443/40923

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/TestProcessor/src/TestProcessor.cc modified in PR(s): Improve Framework behavior after exceptions in begin/end transitions (Job, Stream, ProcessBlock) #45434

[cmsbuild]

Pull request #45443 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45443/40967

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/TestProcessor/src/TestProcessor.cc modified in PR(s): Improve Framework behavior after exceptions in begin/end transitions (Job, Stream, ProcessBlock) #45434

[cmsbuild]

Pull request #45443 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7a52e/40481/summary.html
COMMIT: 9bbc86a
CMSSW: CMSSW_14_1_X_2024-07-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45443/40481/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 254 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345208
• DQMHistoTests: Total failures: 2769
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3342419
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #39803 and 29634.911 (known non-reproducibility, but without a GH issue #45505)

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[srimanob]

Hi @makortel
Strange that the fix is on HGCal, but the failures are not on HGCal at all. Any possibility that something comes between CMSSW_14_1_X_2024-07-15-2300 and now ?

[makortel]

Any possibility that something comes between CMSSW_14_1_X_2024-07-15-2300 and now ?

Of course that is possible, but I'd suspect more an existing issue that was hidden by the HGCal uninitialized variables. For the record, here are the PRs merged after 07-15-2300 up to 07-18-1100

• Use uncorrected H/E for electron energy regressions #45470
• Store track momentum at hit for PbPb UPC dEdX calibration #45446
• Phase2-hgx358C Add a few new modes to enable cog computation for wafers as default for the future V19 version of HGCal #45366
• Fixes for CLANG_X+CPP20 #45428
• (DAQ) Add WatcherSource (ECAL) to DAQ output file unit tests #45465
• Update heavy-ion eras for 2024 + add MC RelVal workflows #45307
• Phase2-gex179 Make a new scenario 2026D115 and workflow 32034.0 for a setup with HFNose and V17 geometry version of HGCal #45375
• fix check on shrEnergyM0TotalAccum in HCAL-Alpaka kernel #45452
• Explicitly initialize bTag #45409
• MTD Validation: update of the BTL SimHit validation #45424
• Phase2-hgx359A Modify some of the scripts in Validation/HGCalValidation/test/python to be in line with the current defaults of scenarios #45437
• Phase2-hgx359B Update the cfg files in Validation/Geometry in view of recent updates of the scenarios #45444
• Phase2-hgx359C Make several updates to the configuration files in Validation/HGCalValidation/test/python in view of updates of Phase2 scenarios #45445
• Phase2-hgx359D Modify the remaining test scripts in Validation/HGCalValidation for the changed phase2 scenarios #45447
• Implement a workaround for -Warray-bounds in LTO builds #45455
• Track selection update in MTD Validation #45457
• Fix pixel CPE position #45471

[rappoccio]

+1