[GCC13] Suppress array-bound error #45179 from PixelSeeding #45340

smuzaffar · 2024-06-28T12:59:06Z

This PR suppresses the array-bound error for RecoTracker/PixelSeeding . It should fix the build errors we get in GCC 13 IBs

cmsbuild · 2024-06-28T12:59:33Z

cms-bot internal usage

smuzaffar · 2024-06-28T13:00:08Z

please test with #45335 for el9_amd64_gcc13

cmsbuild · 2024-06-28T13:06:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45340/40753

This PR adds an extra 16KB to repository

cmsbuild · 2024-06-28T13:06:58Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

RecoTracker/PixelSeeding (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2024-06-28T13:07:22Z

please test

cmsbuild · 2024-06-28T16:55:50Z

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0b315/40144/summary.html
COMMIT: 013d2db
CMSSW: CMSSW_14_1_X_2024-06-26-1200/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45340/40144/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test testTauEmbeddingWorkflow2016preVFP had ERRORS
---> test testTauEmbeddingWorkflow2017 had ERRORS
---> test testTauEmbeddingWorkflow2016postVFP had ERRORS
and more ...

RelVals

29634.911A fatal system signal has occurred: segmentation violation

cmsbuild · 2024-06-28T18:07:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0b315/40145/summary.html
COMMIT: 013d2db
CMSSW: CMSSW_14_1_X_2024-06-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45340/40145/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 2656 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3451610
DQMHistoTests: Total failures: 1046
DQMHistoTests: Total nulls: 4
DQMHistoTests: Total successes: 3450540
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 206 log files, 170 edm output root files, 49 DQM output files
TriggerResults: found differences in 1 / 47 workflows

mandrenguyen · 2024-06-29T12:16:27Z

What's up with the failed relvals and unit tests?

iarspider · 2024-06-29T12:27:14Z

What's up with the failed relvals and unit tests?

RelVal: #41927
Unit tests: #45288

smuzaffar · 2024-06-29T20:58:20Z

What's up with the failed relvals and unit tests?

@mandrenguyen , failed workflows and relvals are for el8/gcc13 , so please ignore those. For productiuon arch , PR results #45340 (comment) look good

fwyzard · 2024-07-01T11:48:21Z

assign heterogeneous

cmsbuild · 2024-07-01T11:48:47Z

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

mandrenguyen · 2024-07-01T20:41:27Z

+1

iarspider · 2024-07-09T09:34:31Z

@cms-sw/heterogeneous-l2 gentle ping

fwyzard · 2024-07-09T11:46:27Z

Rather than changing the flags in the BuildFile.xml of RecoTracker/PixelSeeding/plugins, which simply uses the code, it would be better to push/pop the warning flags in the header itself.

fwyzard · 2024-07-09T11:46:31Z

-heterogeneous

smuzaffar · 2024-07-09T11:51:26Z

@fwyzard , I tried disabling the warning using #pragma push ... pop but that did not work. I can try again but feel free to open a PR with the proper fix

smuzaffar · 2024-07-10T09:44:03Z

@fwyzard , these warnings ( and errors for GCC 13) only happen when we link serial backend [a]. There is one warning for each of https://github.com/cms-sw/cmssw/blob/master/RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernels.dev.cc#L559-L561. Warning array subscript corresponds to maxNumberOfTuples of these pixelTopology::* structures

[a]

>> Building alpaka/serial edm plugin tmp/el8_amd64_gcc12/src/RecoTracker/PixelSeeding/plugins/RecoTrackerPixelSeedingPortableSerialSync/libRecoTrackerPixelSeedingPortableSerialSync.so
In member function 'operator[]',
    inlined from 'size' at src/HeterogeneousCore/AlpakaInterface/interface/OneToManyAssoc.h:144:55,
    inlined from 'operator()' at src/RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernelsImpl.h:553:42,
.....
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:15:60: warning: array subscript 32769 is above array bounds of 'const unsigned int[32769]' [-Warray-bounds]
   15 |     constexpr const I& operator[](int i) const { return m_v[i]; }
      |                                                            ^
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h: In member function 'operator()':
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:21:7: note: while referencing 'm_v'
   21 |     I m_v[S];
      |       ^
In member function 'operator[]',
    inlined from 'size' at src/HeterogeneousCore/AlpakaInterface/interface/OneToManyAssoc.h:144:55,
    inlined from 'operator()' at src/RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernelsImpl.h:553:42,
....
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:15:60: warning: array subscript 262145 is above array bounds of 'const unsigned int[262145]' [-Warray-bounds]
   15 |     constexpr const I& operator[](int i) const { return m_v[i]; }
      |                                                            ^
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h: In member function 'operator()':
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:21:7: note: while referencing 'm_v'
   21 |     I m_v[S];
      |       ^
In member function 'operator[]',
    inlined from 'size' at src/HeterogeneousCore/AlpakaInterface/interface/OneToManyAssoc.h:144:55,
    inlined from 'operator()' at src/RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernelsImpl.h:553:42,
...
src/HeterogeneousCore/AlpakaInterface/interface/FlexiStorage.h:15:60: warning: array subscript 262145 is above array bounds of 'const unsigned int[262145]' [-Warray-bounds]
   15 |     constexpr const I& operator[](int i) const { return m_v[i]; }

fwyzard · 2024-07-10T13:28:02Z

Thanks for the detailed pointers, I'll have a look.

fwyzard · 2024-07-10T17:36:21Z

@fwyzard , I tried disabling the warning using #pragma push ... pop but that did not work. I can try again but feel free to open a PR with the proper fix

I started looking into it, and quickly ended up on the GCC Bugzilla:

:-/

fwyzard · 2024-07-10T17:39:59Z

@smuzaffar is there a way to put these flags into HeterogeneousCore/AlpakaInterface/BuildFile.xml, so that all libraries that depend on HeterogeneousCore/AlpakaInterface get them ?

smuzaffar · 2024-07-10T21:39:26Z

@fwyzard , SCRAM does not export cxxflags from BuildFiles. Only way to export flags is to define a toolfile e.g. array-bound-flag.xml and then add a dependency on it using <use name="array-bound-flag"/> .

Adding such a dependency in HeterogeneousCore/AlpakaInterface/BuildFile.xml means these flags will be passed to all packages ( for default libs/plugins and alpaka backends) which depend on HeterogeneousCore/AlpakaInterface. I would suggest to add array-bound-flag.xml and for now only add it for serail backend of RecoTrackerPixelSeedingPortable e.g. using the following in https://github.com/cms-sw/cmssw/blob/master/RecoTracker/PixelSeeding/plugins/BuildFile.xml#L33

<use name="array-bound-flag" for="alpaka/serail"/>

smuzaffar · 2024-07-15T09:43:11Z

@fwyzard , should we go with the solution I have proposed in #45340 (comment) ?

fwyzard · 2024-07-15T09:47:00Z

Sorry for the delay, I'm slowly catching up after last week's hackathon.

I do like the solution you proposed in #45340 (comment) - but I don't want to push for the extra complexity.

So I'm also fine with adding the flags explicitly in RecoTracker/PixelSeeding/plugins/BuildFile.xml. If you add the CXXFLAGS, can they be added only for="alpaka/serail" ?

smuzaffar · 2024-07-15T09:55:25Z

If you add the CXXFLAGS, can they be added only for="alpaka/serail" ?

<flag CXXFLAGS="flags" for="xyz" > is doable but requires SCRAM and BuildRules changes. I think scram should support it but being a flag it will not be exported to dependent packages.
<use name="array-bound-flag" for="alpaka/serail"/> is already supported and exported by default to dependent packages

fwyzard · 2024-07-15T09:59:58Z

OK, then let's take the fix that requires minimal changes in SCRAM and in the externals (i.e. this one) and replace it with something better if you make changes to SCRAM or if we need to use the same flags somewhere else ?

smuzaffar · 2024-07-15T10:00:15Z

byt he way, we already have ofast-flag toolfile used by various cmssw packages . To avoid exporting such a dependency to dependent packages one can add NO_RECURSIVE_EXPORT flag in toolfile

fwyzard · 2024-07-15T10:00:49Z

Should we rerun the gcc13 tests ?

smuzaffar · 2024-07-15T10:03:12Z

please test for el9_amd64_gcc13

fwyzard · 2024-07-15T10:09:14Z

To avoid exporting such a dependency to dependent packages one can add NO_RECURSIVE_EXPORT flag in toolfile

Ah, I see.

The code that requires the extra flag is in a header file, so I think in this case we should propagate the flag to the packages that depend on it.

fwyzard · 2024-07-15T10:11:22Z

Does cms-sw/cmsdist#9301 look OK ?

smuzaffar · 2024-07-15T10:28:09Z

Does cms-sw/cmsdist#9301 look OK ?

thanks @fwyzard , yes it looks good.
I can update this PR to use the new tool or feel free to open a new PR

fwyzard · 2024-07-15T10:29:27Z

I've opened #45455

cmsbuild · 2024-07-16T04:50:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0b315/40388/summary.html
COMMIT: 013d2db
CMSSW: CMSSW_14_1_X_2024-07-12-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45340/40388/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 14747 lines to the logs
Reco comparison results: 61320 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3451616
DQMHistoTests: Total failures: 359210
DQMHistoTests: Total nulls: 228
DQMHistoTests: Total successes: 3092158
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1.1780000000000002 KiB( 48 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.063 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): 0.799 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): -0.112 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.064 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -1.600 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 8.0 ): -0.262 KiB SiStrip/MechanicalView
Checked 206 log files, 170 edm output root files, 49 DQM output files

smuzaffar · 2024-07-16T07:40:50Z

closing this in favor of #45455

[GCC13] Suppress array-bound error cms-sw#45179

013d2db

cmsbuild added this to the CMSSW_14_1_X milestone Jun 28, 2024

smuzaffar mentioned this pull request Jun 28, 2024

RecoTracker/PixelSeeding: array subscript ... is above array bounds in Alpaka/FlexiStorage #45179

Open

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Jun 28, 2024

cmsbuild added tests-started requires-external and removed tests-pending labels Jun 28, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 28, 2024

cmsbuild removed the requires-external label Jun 28, 2024

smuzaffar changed the title ~~[GCC13] Suppress array-bound error #45179~~ [GCC13] Suppress array-bound error #45179 from PixelSeeding Jun 28, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 28, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 1, 2024

cmsbuild added heterogeneous-rejected and removed heterogeneous-pending labels Jul 9, 2024

smuzaffar mentioned this pull request Jul 11, 2024

Updating c++ default standard to c++20 for 14.1.X #45432

Closed

cmsbuild mentioned this pull request Jul 15, 2024

Implement a workaround for -Warray-bounds in LTO builds #45455

Merged

smuzaffar closed this Jul 16, 2024

[GCC13] Suppress array-bound error #45179 from PixelSeeding #45340

[GCC13] Suppress array-bound error #45179 from PixelSeeding #45340

Conversation

smuzaffar commented Jun 28, 2024

cmsbuild commented Jun 28, 2024 • edited Loading

smuzaffar commented Jun 28, 2024

cmsbuild commented Jun 28, 2024

cmsbuild commented Jun 28, 2024

smuzaffar commented Jun 28, 2024

cmsbuild commented Jun 28, 2024

Unit Tests

RelVals

cmsbuild commented Jun 28, 2024

Comparison Summary

mandrenguyen commented Jun 29, 2024

iarspider commented Jun 29, 2024

smuzaffar commented Jun 29, 2024

fwyzard commented Jul 1, 2024

cmsbuild commented Jul 1, 2024

mandrenguyen commented Jul 1, 2024

iarspider commented Jul 9, 2024

fwyzard commented Jul 9, 2024

fwyzard commented Jul 9, 2024

smuzaffar commented Jul 9, 2024

smuzaffar commented Jul 10, 2024

fwyzard commented Jul 10, 2024

fwyzard commented Jul 10, 2024

fwyzard commented Jul 10, 2024

smuzaffar commented Jul 10, 2024 • edited Loading

smuzaffar commented Jul 15, 2024

fwyzard commented Jul 15, 2024

smuzaffar commented Jul 15, 2024

fwyzard commented Jul 15, 2024

smuzaffar commented Jul 15, 2024

fwyzard commented Jul 15, 2024

smuzaffar commented Jul 15, 2024

fwyzard commented Jul 15, 2024

fwyzard commented Jul 15, 2024

smuzaffar commented Jul 15, 2024

fwyzard commented Jul 15, 2024

cmsbuild commented Jul 16, 2024

Comparison Summary

smuzaffar commented Jul 16, 2024

cmsbuild commented Jun 28, 2024 •

edited

Loading

smuzaffar commented Jul 10, 2024 •

edited

Loading