[CPP20][SIMULATION] Remove deprecated enum arithmetic

[iarspider]

PR description:

Some arithmetic and logic operations on enums are deprecated in C++20. This PR aims to fix these.

PR validation:

Bot tests.

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44491/39580

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• SimCalorimetry/EcalSimAlgos (simulation)
• SimCalorimetry/EcalSimProducers (simulation)
• SimCalorimetry/HcalSimAlgos (simulation)

@mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@ReyerBand, @abdoulline, @wang0jin, @sameasy, @thomreis, @argiro, @bsunanda, @rchatter, @rovere, @mariadalfonso this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6038ec/38291/summary.html
COMMIT: 5dea8f7
CMSSW: CMSSW_14_1_CPP20_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44491/38291/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Fix plugin library name AlpakaCore/plugins/BuildFile.xml #44445
• @germanfgv Add NanoAOD flavours parameter to PromptReco #44430
• @valsdav DeepTau - Do not call TF inference with empty grid #44455
• @fwyzard Fix track sort order in PixelTrackProducerFromSoAAlpaka #44441
• @Dr15Jones Use default operator= in CondFormats/CSCObjects #44462
• @smuzaffar Remove unused strstream to fix the deprecated header warning #44426
• @iarspider [AArch64, PowerPC] Fix deprecated-copy warnings in extBasic{2,3}DVector #44448
• @aehart KalmanFilter fix for Phase 2 L1 tracking #44427
• @valsdav Improve handling of TF CUDA tests for 14_1_X #44376
• @vlimant adding JME nano in autoNano #44087
• @swagata87 Produce r9 and trackIso(hollow cone) in EGamma development path #44423
• @stahlleiton Add use of unsubtracted jets in RecoBTag info producers #44422
• @fwyzard Update the HLT alpaka customisation #44439
• @mmusich MillePedeAlignmentAlgorithm: add a unit test for the mille step #44434
• @watson-ij Allow storing 2024 geometry in GEMGeometryParsFromDD #44429

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6038ec/38291/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6038ec/38291/git-merge-result

Comparison Summary

Summary:

• You potentially added 2250 lines to the logs
• Reco comparison results: 123 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 502
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3296847
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 5 / 46 workflows

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

@iarspider , I just read a comment from Matti in #44488 , may be better to try it out?

[antoniovilela]

-orp

• Implementation will be updated.

[antoniovilela]

@iarspider
Hi Ivan, will you update this PR, or should it be closed?
Thanks.