[CPP20][SIMULATION] Replace some enums with constexpr int

[iarspider]

PR description:

Replace some enums with constexpr ints to avoid deprecated enum arithmetics. Replaces #44491 following @makortel's suggestion.

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44535/39666

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimCalorimetry/EcalSimAlgos/interface/EcalSignalGenerator.h modified in PR(s): [CPP20][SIMULATION] Remove deprecated enum arithmetic #44491

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• SimCalorimetry/CaloSimAlgos (simulation)
• SimCalorimetry/EcalSimAlgos (simulation)

@mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@wang0jin, @sameasy, @ReyerBand, @thomreis, @argiro, @rchatter, @rovere this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a2075/38392/summary.html
COMMIT: ed5b455
CMSSW: CMSSW_14_1_CPP20_X_2024-03-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44535/38392/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Use default op= in LASModuleProfile #44463
• @bsunanda Phase2-gex177 Make a new PR to have the geometry scenario ExtendedGeometry2026D110 which represents T35+C18+M11+I17+O9+F8 #44493
• @makortel Initialize statsGuard_ on LogErrorEventFilter #44447
• @stahlleiton Run3 era for 2024 pp reference and UPC reco #44316
• @bsunanda Phase2-hgx354B First attempt to prepare components of XML file for the scintillator components in the mixed layers of HGCal #44478
• @vlimant fix standard and upgrade validation workflows #44464
• @rdelliga MTD Validation: Characterization of PU contribution in vertices #44405
• @Dr15Jones Modified message from MaxMemoryPreload #44502
• @RSalvatico Modify trigger filterBits for electrons and photons in custom EGM Nano #44496
• @Dr15Jones Moved modules.py out of edmWriteConfig #44396

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a2075/38392/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a2075/38392/git-merge-result

Comparison Summary

Summary:

• You potentially added 2231 lines to the logs
• Reco comparison results: 131 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 1854
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 3295492
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 30.714 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 5.119 KiB MTD/Vertices
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1