Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MillePedeAlignmentAlgorithm: add a unit test for the mille step #44434

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 16, 2024

PR description:

Issue #44188 showed that we're liable against possible changes in the external libraries (millepede and gbl) used for running complex alignment campaigns, as there is no dedicated test for that.
This PR transforms the reproducer of issue #44188 into a unit test, using input Z → µµ ALCARECO data and running the mille step of the alignment procedure. The test gives also provision for running the pede one, but for timing reasons this is not exercised in central tests.

PR validation:

scram b runtests_test_MilleZmm runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be backported to CMSSW_14_0_X for monitoring of the data-taking release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44434/39510

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)

@saumyaphor4252, @perrotta, @consuegs, @cmsbuild can you please review it and eventually sign? Thanks.
@adewit, @rsreds, @tocheng, @yuanchao, @mmusich, @tlampen this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 16, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44afb0/38190/summary.html
COMMIT: aaae750
CMSSW: CMSSW_14_1_X_2024-03-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44434/38190/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

@mmusich the unit test is technically successfull.
Is the output the one expected?

===== Test "test_MilleZmm" ====
testing mille step ...
Using Global Tag: 140X_dataRun3_ForTkAlReReco_v1
# MSG-i trackselectionRefitting:  g4Refitting=False
 GblPoint::getDerivatives failed to invert matrix 
 Possible reason for singular matrix: multiple GblPoints at same arc-length
 GblTrajectory construction failed: Singular matrix inversion exception
 GblPoint::getDerivatives failed to invert matrix 
 Possible reason for singular matrix: multiple GblPoints at same arc-length
 GblTrajectory construction failed: Singular matrix inversion exception

---> test test_MilleZmm succeeded
TestTime:276
^^^^ End Test test_MilleZmm ^^^^

@mmusich
Copy link
Contributor Author

mmusich commented Mar 18, 2024

Is the output the one expected?

apparently so.
Screenshot from 2024-03-18 14-43-52

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants