Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Run3 era for updated HB thresholds in 2023 #41271

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

swagata87
Copy link
Contributor

PR description:

Creating a new era to update HB thresholds.
This PR is essentially doing similar things as done in #40689 and #40756 for 12_6_X.

PR validation:

Checked with 12434.0

This PR needs to be back-ported to data-taking release 13_0_X.

FYI @cms-sw/hcal-dpg-l2 @cms-sw/pf-l2 @francescobrivio @davidlange6

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41271/35030

  • This PR adds an extra 28KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)
  • Configuration/Eras (operations)
  • Configuration/StandardSequences (operations)
  • RecoEgamma/EgammaIsolationAlgos (reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)

@perrotta, @rappoccio, @clacaputo, @cmsbuild, @mandrenguyen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @jainshilpi, @Martin-Grunewald, @a-kapoor, @lgray, @mmusich, @seemasharmafnal, @mmarionncern, @makortel, @JanFSchulte, @dgulhan, @missirol, @Prasant1993, @slomeo, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @hatakeyamak, @ebrondol, @mtosi, @fabiocos, @AnnikaStein, @varuns23, @valsdav, @sobhatta, @afiqaize, @wrtabb, @sameasy, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41271/35032

  • This PR adds an extra 32KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2023

Pull request #41271 was updated. @perrotta, @rappoccio, @clacaputo, @cmsbuild, @mandrenguyen, @fabiocos, @davidlange6 can you please check and sign again.

@francescobrivio
Copy link
Contributor

FYI also
PPD: @jordan-martins
ORMs: @saumyaphor4252 @malbouis

@francescobrivio
Copy link
Contributor

@davidlange6

@davidlange6 sorry I took the liberty to suggest Swagata to ping you here in order to double check that this is the correct (and best) way to implement the scenario that will eventually be deployed in Tier0. Thanks!

@swagata87
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67de5d/31853/summary.html
COMMIT: cd20719
CMSSW: CMSSW_13_1_X_2023-04-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41271/31853/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3365163
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3365135
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 202 log files, 155 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

I think I don't like Run3 as it does not specific on year, that is the main reason that I think it should represent the most recent.

Just thinking out loud, how about creating setting up all Run3_202{2,3,4,5} (even if {3,4,5} would have equal content) now?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67de5d/31965/summary.html
COMMIT: cd20719
CMSSW: CMSSW_13_1_X_2023-04-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41271/31965/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 2251 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3619444
  • DQMHistoTests: Total failures: 1169
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618253
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 212 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

I agree with @makortel
That is maybe a good thing to make a clear on Era. Maybe this PR and #41319 can be merged first, and we come with a new PR to arrange this setting.

@mandrenguyen
Copy link
Contributor

+reconstruction
Latest test show differences in the expected places in wfs 12402 and 12434.
This demonstrates that the changes to the HB thresholds are having the desired effect.

As mentioned here #41271 (comment)
there needs to be subsequent PR to clean up the way the run 3 eras are dealt with.

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 2904e12 into cms-sw:master Apr 17, 2023
@swagata87
Copy link
Contributor Author

thanks, so I will prepare a backport to data-taking release (13_0_X)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants