HLT menu development for 13_0_X (8/N): GRun menu V1.1 of 2023 [13_2_X]

[missirol]

PR description:

Development of HLT menus for CMSSW_13_0_X.

This is the PR for the master branch, which will then be backported down to 13_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This version of the GRun HLT menu corresponds to the "V1.1" menu for 2023 pp data-taking, and the corresponding frozen menu is added to the release replacing the 2023-V1.0 frozen menu.

In addition, the era used for the L1REPACK and (HLT+)RECO steps in the HLT-Validation tests and HLT-addon tests is changed from Run3 to Run3_2023 (see #41271). This is done mainly to follow what currently runs in the prompt offline reconstruction of 2023 data.

This update includes the integration of the following JIRA tickets.

• CMSHLT-2695: [HIG] new HH4b triggers for ParkingHH dataset
• CMSHLT-2697: [HIG] retuning of HLT_Diphoton30_18_R9IdL* triggers
• CMSHLT-2702: [HIG,EXO] new triggers for VBF parking
• CMSHLT-2734: [HIG] addition of HLT_Photon60_*_PFJetsMJJ300DEta3_v to EGamma PD(s)
• CMSHLT-2743: [EXO] displaced-jets triggers for LLP parking
• CMSHLT-2744: [EXO] delayed-jets triggers for LLP parking
• CMSHLT-2747: [HCAL] increase HB-RecHit thresholds for 2023 data-taking
• CMSHLT-2748: [JME,HCAL] replace L1_SingleJet35* seeds with L1_ZeroBias in triggers of GRun menu
• CMSHLT-2750: [HIG] correct bugged instances of HLTPFJetTag in MSSM-Hbb triggers
• CMSHLT-2754: [EXO] delayed-jet and delayed-photon triggers for "satellite" collisions
• CMSHLT-2756: [MUO] update of muon-InsideOut seed-classifier BDT training and wp for 2023
• CMSHLT-2759: [HIG,B2G] PNet trainings for 2023 and update of PNet-WPs in all PNet-based triggers
• CMSHLT-2760: [HCAL] removal of HLT_HcalIsolatedbunch_v trigger and IsolatedBunch dataset
• CMSHLT-2772: [HIG] additional control triggers for VBF HToCC search
• CMSHLT-2780: [HIG,B2G,TOP] move some HT+Jet+BTag triggers to ParkingHH dataset
• CMSHLT-2791: [EXO] set PS=0 for HLT_HT200_L1SingleLLPJet_DisplacedDijet35_Inclusive1PtrkShortSig5_v

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_1_X
CMSSW_13_0_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41600/35494

• This PR adds an extra 1236KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/HLT/python/autoCondHLT.py modified in PR(s): remove 2022 HLT menu from CMSSW_13_X_Y #41471
  • File HLTrigger/Configuration/python/Tools/options.py modified in PR(s): remove 2022 HLT menu from CMSSW_13_X_Y #41471
  • File HLTrigger/Configuration/test/cmsDriver.csh modified in PR(s): remove 2022 HLT menu from CMSSW_13_X_Y #41471
  • File HLTrigger/Configuration/test/getFrozenHLT.sh modified in PR(s): remove 2022 HLT menu from CMSSW_13_X_Y #41471
  • File HLTrigger/Configuration/test/runIntegration.csh modified in PR(s): remove 2022 HLT menu from CMSSW_13_X_Y #41471
  • File HLTrigger/Configuration/test/runOne.csh modified in PR(s): remove 2022 HLT menu from CMSSW_13_X_Y #41471

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• Configuration/HLT (hlt)
• HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

enable gpu

[missirol]

please test

[cmsbuild]

-1

Failed Tests: RelVals-GPU
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19a0bb/32514/summary.html
COMMIT: 15c263f
CMSSW: CMSSW_13_2_X_2023-05-09-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41600/32514/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-GPU

• 12434.58712434.587_TTbar_14TeV+2023_Patatrack_AllTripletsGPU_Validation/step2_TTbar_14TeV+2023_Patatrack_AllTripletsGPU_Validation.log
• 12434.58612434.586_TTbar_14TeV+2023_Patatrack_AllTripletsGPU/step2_TTbar_14TeV+2023_Patatrack_AllTripletsGPU.log

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3457090
• DQMHistoTests: Total failures: 1470
• DQMHistoTests: Total nulls: 17
• DQMHistoTests: Total successes: 3455581
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1407.75 KiB( 47 files compared)
• DQMHistoSizes: changed ( 12434.0,... ): 1311.863 KiB HLT/JME
• DQMHistoSizes: changed ( 12434.0,... ): -698.739 KiB HLT/EXO
• DQMHistoSizes: changed ( 12434.0 ): 74.142 KiB HLT/HLTEgammaValidation
• DQMHistoSizes: changed ( 12434.0,... ): 42.772 KiB HLT/EGM
• DQMHistoSizes: changed ( 12434.0 ): -39.886 KiB HLT/HIG
• DQMHistoSizes: changed ( 12434.0 ): 21.206 KiB HLT/TAU
• DQMHistoSizes: changed ( 12434.0,... ): 18.232 KiB HLT/Filters
• DQMHistoSizes: changed ( 139.001 ): 4.030 KiB HLT/TAU
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[missirol]

please test

"out of memory" errors in GPU RelVals (seen also in other unrelated PRs). Let's see how persistent they are.

----- Begin Fatal Exception 09-May-2023 19:41:57 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'DQM_PixelReconstruction_v6'
   [2] Calling method for module CAHitNtupletCUDAPhase1/'hltPixelTracksGPU'
Exception Message:
A std::exception was thrown.

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/8f3ac16587615c47f30af53fed2bf47e/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_2_X_2023-05-09-1100/src/RecoTracker/PixelSeeding/plugins/CAHitNtupletGeneratorKernels.cu, line 63:
cudaCheck(cudaGetLastError());
cudaErrorMemoryAllocation: out of memory

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19a0bb/32523/summary.html
COMMIT: 15c263f
CMSSW: CMSSW_13_2_X_2023-05-09-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41600/32523/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3457090
• DQMHistoTests: Total failures: 1473
• DQMHistoTests: Total nulls: 17
• DQMHistoTests: Total successes: 3455578
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1407.75 KiB( 47 files compared)
• DQMHistoSizes: changed ( 12434.0,... ): 1311.863 KiB HLT/JME
• DQMHistoSizes: changed ( 12434.0,... ): -698.739 KiB HLT/EXO
• DQMHistoSizes: changed ( 12434.0 ): 74.142 KiB HLT/HLTEgammaValidation
• DQMHistoSizes: changed ( 12434.0,... ): 42.772 KiB HLT/EGM
• DQMHistoSizes: changed ( 12434.0 ): -39.886 KiB HLT/HIG
• DQMHistoSizes: changed ( 12434.0 ): 21.206 KiB HLT/TAU
• DQMHistoSizes: changed ( 12434.0,... ): 18.232 KiB HLT/Filters
• DQMHistoSizes: changed ( 139.001 ): 4.030 KiB HLT/TAU
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 40073
• DQMHistoTests: Total failures: 39
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 40034
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 6 edm output root files, 3 DQM output files
• TriggerResults: found differences in 2 / 2 workflows

[missirol]

+hlt

• changes in the outputs of PR tests are in line with updates to the HLT GRun menu, and the change in name of the fake HLT menus
• widespread, albeit seemingly small, differences in HLT-DQM outputs are in line with low-level changes to the HLT reconstruction (e.g. thresholds of HB-RecHits, change to one working-point of the HLT-muon reconstruction)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1