-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of input collection parameters to untracked for CTPPS and DTMonitorModule #38854
Migration of input collection parameters to untracked for CTPPS and DTMonitorModule #38854
Conversation
Code check Take care of Tamas's comment Remove the commente dout code Code check handle clang error Code check
bugfix bugfix remove commented lines add L1TStage2CPPF cfi clear comments code-checks and format LogInfo to Warning remove couts src to plugins clang format
General notes: - code in the alpaka subdirectories is compiled multiple times, once for each backend; this is controlled by the ALPAKA_BACKENDS flag in each package or plugins BuildFile.xml; - code in .cc files is always compiled by the host compiler; - code in .dev.cc files is compiled the respective device compiler: nvcc for CUDA, hipcc for HIP, gcc for the serial or tbb backends. The HeterogeneousCore/AlpakaInterface package provides an interface to the header-only alpaka external library. It provides a definition of the common types and macros used in CMSSW, of the host types, and of the accelertor devices, queues and events for each backend. It also provides a free function to access the common host object. This package can safely be used by DataFormats packages. The DataFormats/Portable package implements template wrappers for persistent host-only collections, transient device-only collections, and common interface for both. See DataFormats/Portable/README.md for more information. The DataFormats/PortableTestObjects package implements portable SoA-based data formats used for testing the alpaka build rules and the SoA templates. The HeterogeneousCore/AlpakaTest package implements modules for producing, transferring, and analysing those objects. See HeterogeneousCore/AlpakaTest/test/ for unit tests for writing and reading SoA data structures. The HeterogeneousCore/AlpakaServices provides simple services for checking the availability of devices for each alpaka backend.
Implement a ConstBuffer interface for non-mutable buffers, based on alpaka::ViewConst<Buffer> . Remove the LogDebug messages from the constructors and destructors.
This lets the compiler automatically convert a View to a ConstView when passed by pointer or by reference, emulating the usual conversion rules for mutable/const pointers and references. Various improvements: - fix const correctness in View::Metadata and SoAColumnAccessorsImpl; - make SOA_INLINE always inline also on the host; - simplify the Matryoshka templates; - use the __trap() intrinsic in gpu code; - replace typedef with using; - add missing type aliases; - add defaulted copy/move ctors and dtors; - make various methods constexpr; - add and update comments, remove unused methods and macros; - improve spacing and indentations; - apply code formatting.
This is limited to view trivially deducted from layouts, not the manually defined ones.
…ad are encountered
…n and macros in SimG4CMS/Calo
Phase2-hgx319E Update the test scripts in Geometry/HGCalGeometry/test/python
Replace_Geometry_cff with GeometryDB_cff in RecoVertex
Check for nans earlier in the template reco
Add missing #include to EdmProvDump.cc
Try to fix GeometryProducer and G4e examples
Pull request #38854 was updated. @SiewYan, @rappoccio, @gouskos, @bbilin, @pmandrik, @ianna, @Saptaparna, @ggovi, @bsunanda, @alberto-sanchez, @ChrisMisan, @cecilecaillol, @perrotta, @civanch, @yuanchao, @vlimant, @makortel, @ahmad3213, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @davidlange6, @smuzaffar, @Dr15Jones, @epalencia, @swertz, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @kskovpen, @jpata, @qliphy, @micsucmed, @fabiocos, @francescobrivio, @malbouis, @mkirsano, @jordan-martins, @rekovic, @clacaputo, @srimanob, @mariadalfonso, @tvami, @rvenditti can you please check and sign again. |
PR description:
This PR has switched all the input collection tracked parameters of DQM/CTPPS ns DQM/DTMonitorModule to untracked, followed by the discussion: #36998 (comment)
For CTPPS,
Number of source files changed: 9
Number of python configurations changed: 7
Number of parameters changed: 32
For DTMonitorModule,
Number of source files changed: 12
Number of python configurations changed: 14
Number of parameters changed: 22
PR validation:
Tested in CMSSW_12_4_X via runTheMatrix.py -l limited -i all --ibeos
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
NA