Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Unpack uGT testcrate data #37481

Closed
wants to merge 2 commits into from

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Apr 6, 2022

PR description:

This enables unpacking of the data taken from the uGT testcrate

PR validation:

Ran the usual suite of scram b -j 16 runtests and runTheMatrix.py -l limited -i all --ibeos. Validation with data taken ongoing.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37481/29183

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)
  • L1Trigger/Configuration (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@dinyar dinyar marked this pull request as draft April 6, 2022 15:00
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37481/29186

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

Pull request #37481 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0d090/23703/summary.html
COMMIT: 9d01756
CMSSW: CMSSW_12_4_X_2022-04-06-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37481/23703/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593009
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

@dinyar Can you please close this PR if it is not needed anymore?

@dinyar
Copy link
Contributor Author

dinyar commented Sep 1, 2022

Hi Cecile,

Sure, done.

Cheers,
Dinyar

@dinyar dinyar closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants