Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_4_X] Inherit AlCaPPS_Run3 from AlCa #38838

Merged
merged 1 commit into from
Jul 25, 2022
Merged

[12_4_X] Inherit AlCaPPS_Run3 from AlCa #38838

merged 1 commit into from
Jul 25, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jul 22, 2022

PR description:

See #38837

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38837

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

Backport of #38837

@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Jul 22, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 22, 2022 •
edited
Loading

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@perrotta, @rappoccio, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022 •
edited
Loading

type bugfix,ctpps

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

urgent

  • needed for data taking

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

@cmsbuild , please test

  • relying on unit tests in CMSSW, otherwise real validation is done as described in the description

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

assign alca

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-95b8f0/26406/summary.html
COMMIT: e3dc9cc
CMSSW: CMSSW_12_4_X_2022-07-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38838/26406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3676168
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

malbouis
malbouis reviewed Jul 24, 2022
View reviewed changes
Configuration/DataProcessing/python/Impl/AlCaPPS_Run3.py
from Configuration.DataProcessing.Utils import stepALCAPRODUCER,dqmIOSource,harvestingMode,dictIO,gtNameAndConnect,addMonitoring
from Configuration.Eras.Era_Run3_cff import Run3
import FWCore.ParameterSet.Config as cms

class AlCaPPS_Run3(Scenario):
class AlCaPPS_Run3(AlCa):
def __init__(self):
Scenario.__init__(self)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I'm wrong, but I would think that this should be the AlCa class being initialised here, instead of the Scenario one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm probably that would be better. But it does work like this too... My understanding is that it initializes the Scenario but inherits from AlCa, so when the harvesting function was missing earlier now it's included. The only missing part so far was this harvesting function, the rest worked with Scenario too. So that's why I think this works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it works, I'd prefer to keep it like this. Do you agree?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree.

@qliphy
Copy link
Contributor

qliphy commented Jul 25, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit fb69518 into cms-sw:CMSSW_12_4_X Jul 25, 2022
@cmsbuild cmsbuild mentioned this pull request Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malbouis malbouis malbouis left review comments

Assignees
No one assigned
Labels
alca-approved backport-ok bug-fix ctpps fully-signed operations-approved orp-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_12_4_X
Development

Successfully merging this pull request may close these issues.
5 participants
@tvami @cmsbuild @francescobrivio @qliphy @malbouis