-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit AlCaPPS_Run3 from AlCa #38837
Conversation
type bugfix,ctpps |
urgent
|
@cmsbuild , please test
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38837/31219
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@perrotta, @qliphy, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
assign alca |
New categories assigned: alca @yuanchao,@francescobrivio,@malbouis,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebf92e/26405/summary.html Comparison SummarySummary:
|
+1 |
@cms-sw/orp-l2 we are essentially fully signed |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Recent failure at T0 revealed that
AlCaPPS_Run3
was missing some functions, this PR fixes that.PR validation:
leads to
w/o this PR.
After this PR it runs fine.
Unit test also works.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but needs to go back to 12_4_X