Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_4_X] Inherit AlCaPPS_Run3 from AlCa #38838

Merged
merged 1 commit into from
Jul 25, 2022
Merged

[12_4_X] Inherit AlCaPPS_Run3 from AlCa #38838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Configuration/DataProcessing/python/Impl/AlCaPPS_Run3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@
import sys

from Configuration.DataProcessing.Scenario import *
from Configuration.DataProcessing.Impl.AlCa import AlCa
from Configuration.DataProcessing.Utils import stepALCAPRODUCER,dqmIOSource,harvestingMode,dictIO,gtNameAndConnect,addMonitoring
from Configuration.Eras.Era_Run3_cff import Run3
import FWCore.ParameterSet.Config as cms

class AlCaPPS_Run3(Scenario):
class AlCaPPS_Run3(AlCa):
def __init__(self):
Scenario.__init__(self)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I'm wrong, but I would think that this should be the AlCa class being initialised here, instead of the Scenario one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm probably that would be better. But it does work like this too... My understanding is that it initializes the Scenario but inherits from AlCa, so when the harvesting function was missing earlier now it's included. The only missing part so far was this harvesting function, the rest worked with Scenario too. So that's why I think this works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it works, I'd prefer to keep it like this. Do you agree?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree.

self.eras=Run3
Expand Down