Adding Xi, Chi_c and Chi_b to the matrix for RelVals. #38494

AdrianoDee · 2022-06-24T11:49:28Z

PR description:

Adding Xi, Chi_c and Chi_b wfs to the list of the upgrade wfs to be used in the release validation studies.

Restoring proper ordering for Bu and Psi workflows.

~~Note that, if #38466 goes in, the naming, the number of events and jobs will be changed accordingly for the Xi wf.~~

PR validation:

~~Tested with 11715.0, 11716.0 and 11717.0.~~
Tested with 11739.0, 11740.0, 11741.0, 11742.0, 11743.0.

cmsbuild · 2022-06-24T11:57:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38494/30718

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): fix VectorHits workflows with PU #38468, HLT menu development for 12_4_X (4/N) + migration to 12_4_0 + frozen menu V1.2 for 2022 [12_5_X] #38482, Add run3 tracking low pu era #33532

cmsbuild · 2022-06-24T11:58:18Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2022-06-24T12:01:02Z

test parameters:

workflow = 11715.0,11716.0,11717.0

AdrianoDee · 2022-06-24T12:02:43Z

please test

jordan-martins · 2022-06-24T12:04:56Z

+1

perrotta · 2022-06-24T12:14:33Z

Note that, if #38466 goes in, the naming, the number of events and jobs will be changed accordingly for the Xi wf.

I would expect #38466 can get finally signed by @cms-sw/generators-l2 once the tests finish for it, and the intention is to merge it right after. Perhaps we can save time if you rename accordingly in this PR since now, and test it together with #38466 to avoid crashes

Saptaparna · 2022-06-24T12:17:08Z

Yes, exactly! Will sign the #38466 as soon as possible.

kpedro88 · 2022-06-24T12:55:32Z

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

@@ -2299,6 +2299,9 @@ def __init__(self, howMuch, dataset):
    ('BsToJpsiPhi_mumuKK_14TeV_TuneCP5_cfi', UpgradeFragment(Kby(910,9090),'BsToJpsiPhi_mumuKK_14TeV')), # 1.1%
    ('BuToJPsiPrimeKToJPsiPiPiK_14TeV_TuneCP5_pythia8_cfi', UpgradeFragment(Kby(223,2222),'BuToJPsiPrimeKToJPsiPiPiK_14TeV')), # 5.7%
    ('Psi2SToJPsiPiPi_14TeV_TuneCP5_pythia8_cfi', UpgradeFragment(Kby(45,500),'Psi2SToJPsiPiPi_14TeV')), # 24.6%
+    ('XiMinus_14TeV_SoftQCDInel_TuneCP5_cfi', UpgradeFragment(Kby(9000,90000),'XiMinus_14TeV')), #1.1% (2%)


Historically, we have added new fragments to the end of the list to avoid changing the workflow numbers for existing fragments. @cms-sw/pdmv-l2 should comment if this policy should still be followed.

I think a modifications just like this just went into the release. But whatever the policy I'll follow it.

I think this #38397 is a mistake. We should preserve the order of the workflow. FYI @kskovpen

Hi Adriano, my apologies, let's preserve the order, as was mentioned by @kpedro88 and @srimanob. I keep forgetting about this restriction.

I'll fix it for both. No prob

Thanks Adriano!

Should be properly ordered now, and sorry for signing hasty #38397.

cmsbuild · 2022-06-24T15:47:19Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9e1ed/25759/summary.html
COMMIT: 8fda236
CMSSW: CMSSW_12_5_X_2022-06-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38494/25759/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9e1ed/25759/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9e1ed/25759/git-merge-result

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

11725.0DAS Error
11925.0DAS Error

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 61 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3659125
DQMHistoTests: Total failures: 20
DQMHistoTests: Total nulls: 64
DQMHistoTests: Total successes: 3659019
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 87831.70199999998 KiB( 49 files compared)
DQMHistoSizes: changed ( 1000.0 ): 5.561 KiB AlCaReco/TkAlDiMuonAndVertex
DQMHistoSizes: changed ( 10024.0,... ): 200.027 KiB GEM/RecHits
DQMHistoSizes: changed ( 10024.0,... ): 7.764 KiB GEM/Digis
DQMHistoSizes: changed ( 11634.0,... ): 2034.563 KiB GEM/EventInfo
DQMHistoSizes: changed ( 11634.0,... ): 456.305 KiB GEM/RecHits
DQMHistoSizes: changed ( 11634.0,... ): 202.308 KiB GEM/DAQStatus
DQMHistoSizes: changed ( 11634.0,... ): 77.393 KiB GEM/Digis
DQMHistoSizes: changed ( 138.4,... ): 1798.537 KiB GEM/EventInfo
DQMHistoSizes: changed ( 138.4,... ): 353.492 KiB GEM/RecHits
DQMHistoSizes: changed ( 138.4,... ): 194.687 KiB GEM/DAQStatus
DQMHistoSizes: changed ( 138.4 ): ...
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

- restoring proper ordering in relvals also for Bu and Psi

AdrianoDee · 2022-06-24T16:19:33Z

test parameters:

workflow = 11739.0,11740.0,11741.0,11742.0,11743.0
pull_request = Update XiMinus_14TeV_SoftQCDInel_TuneCP5 config #38466

cmsbuild · 2022-06-24T16:20:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38494/30722

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): fix VectorHits workflows with PU #38468, HLT menu development for 12_4_X (4/N) + migration to 12_4_0 + frozen menu V1.2 for 2022 [12_5_X] #38482, Add run3 tracking low pu era #33532

cmsbuild · 2022-06-24T16:21:17Z

Pull request #38494 was updated. @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

AdrianoDee · 2022-06-24T16:22:25Z

please test

cmsbuild · 2022-06-24T20:13:34Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9e1ed/25767/summary.html
COMMIT: 6061018
CMSSW: CMSSW_12_5_X_2022-06-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38494/25767/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9e1ed/25767/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9e1ed/25767/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 61 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3659125
DQMHistoTests: Total failures: 17
DQMHistoTests: Total nulls: 63
DQMHistoTests: Total successes: 3659023
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 87831.70599999998 KiB( 49 files compared)
DQMHistoSizes: changed ( 1000.0 ): 5.561 KiB AlCaReco/TkAlDiMuonAndVertex
DQMHistoSizes: changed ( 10024.0,... ): 200.027 KiB GEM/RecHits
DQMHistoSizes: changed ( 10024.0,... ): 7.764 KiB GEM/Digis
DQMHistoSizes: changed ( 11634.0,... ): 2034.563 KiB GEM/EventInfo
DQMHistoSizes: changed ( 11634.0,... ): 456.305 KiB GEM/RecHits
DQMHistoSizes: changed ( 11634.0,... ): 202.308 KiB GEM/DAQStatus
DQMHistoSizes: changed ( 11634.0,... ): 77.393 KiB GEM/Digis
DQMHistoSizes: changed ( 138.4,... ): 1798.537 KiB GEM/EventInfo
DQMHistoSizes: changed ( 138.4,... ): 353.492 KiB GEM/RecHits
DQMHistoSizes: changed ( 138.4,... ): 194.687 KiB GEM/DAQStatus
DQMHistoSizes: changed ( 138.4 ): ...
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

perrotta · 2022-06-27T21:23:52Z

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 what is the status of this PR? Do you still intend to include its backport into 12_4_1?

kskovpen · 2022-06-28T08:10:27Z

+pdmv

AdrianoDee · 2022-06-28T08:12:45Z

+upgrade
Add BPH wf to relval productions.

cmsbuild · 2022-06-28T08:13:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-06-28T08:13:44Z

+1

cmsbuild added this to the CMSSW_12_5_X milestone Jun 24, 2022

cmsbuild added code-checks-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Jun 24, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 24, 2022

AdrianoDee mentioned this pull request Jun 24, 2022

[12_4_X] Adding BPH wfs to relval matrix #38495

Merged

cmsbuild added tests-started and removed tests-pending labels Jun 24, 2022

cmsbuild added pdmv-approved and removed pdmv-pending labels Jun 24, 2022

kpedro88 reviewed Jun 24, 2022

View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Jun 24, 2022

Adding Xi, Chic and Chib to the matrix

6061018

- restoring proper ordering in relvals also for Bu and Psi

AdrianoDee force-pushed the bph_wfs_125 branch from 8fda236 to 6061018 Compare June 24, 2022 16:13

cmsbuild removed tests-rejected pdmv-approved code-checks-approved labels Jun 24, 2022

cmsbuild added pdmv-pending tests-pending labels Jun 24, 2022

cmsbuild added the requires-external label Jun 24, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 24, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 24, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 24, 2022

cmsbuild added pdmv-approved and removed pdmv-pending labels Jun 28, 2022

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Jun 28, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 28, 2022

cmsbuild merged commit ef88464 into cms-sw:master Jun 28, 2022

cmsbuild mentioned this pull request Jun 28, 2022

Integration of alpaka and macro-based SoA in CMSSW #37716

Closed

2 tasks

AdrianoDee deleted the bph_wfs_125 branch February 17, 2023 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Xi, Chi_c and Chi_b to the matrix for RelVals. #38494

Adding Xi, Chi_c and Chi_b to the matrix for RelVals. #38494

AdrianoDee commented Jun 24, 2022 •

edited

Loading

cmsbuild commented Jun 24, 2022

cmsbuild commented Jun 24, 2022

AdrianoDee commented Jun 24, 2022

AdrianoDee commented Jun 24, 2022

jordan-martins commented Jun 24, 2022

perrotta commented Jun 24, 2022

Saptaparna commented Jun 24, 2022

kpedro88 Jun 24, 2022

AdrianoDee Jun 24, 2022

srimanob Jun 24, 2022

kskovpen Jun 24, 2022

AdrianoDee Jun 24, 2022 •

edited

Loading

kskovpen Jun 24, 2022

AdrianoDee Jun 24, 2022 •

edited

Loading

cmsbuild commented Jun 24, 2022

AdrianoDee commented Jun 24, 2022

cmsbuild commented Jun 24, 2022

cmsbuild commented Jun 24, 2022

AdrianoDee commented Jun 24, 2022

cmsbuild commented Jun 24, 2022

perrotta commented Jun 27, 2022

kskovpen commented Jun 28, 2022

AdrianoDee commented Jun 28, 2022

cmsbuild commented Jun 28, 2022

perrotta commented Jun 28, 2022

Adding Xi, Chi_c and Chi_b to the matrix for RelVals. #38494

Adding Xi, Chi_c and Chi_b to the matrix for RelVals. #38494

Conversation

AdrianoDee commented Jun 24, 2022 • edited Loading

PR description:

PR validation:

cmsbuild commented Jun 24, 2022

cmsbuild commented Jun 24, 2022

AdrianoDee commented Jun 24, 2022

AdrianoDee commented Jun 24, 2022

jordan-martins commented Jun 24, 2022

perrotta commented Jun 24, 2022

Saptaparna commented Jun 24, 2022

kpedro88 Jun 24, 2022

Choose a reason for hiding this comment

AdrianoDee Jun 24, 2022

Choose a reason for hiding this comment

srimanob Jun 24, 2022

Choose a reason for hiding this comment

kskovpen Jun 24, 2022

Choose a reason for hiding this comment

AdrianoDee Jun 24, 2022 • edited Loading

Choose a reason for hiding this comment

kskovpen Jun 24, 2022

Choose a reason for hiding this comment

AdrianoDee Jun 24, 2022 • edited Loading

Choose a reason for hiding this comment

cmsbuild commented Jun 24, 2022

RelVals-INPUT

Comparison Summary

AdrianoDee commented Jun 24, 2022

cmsbuild commented Jun 24, 2022

cmsbuild commented Jun 24, 2022

AdrianoDee commented Jun 24, 2022

cmsbuild commented Jun 24, 2022

Comparison Summary

perrotta commented Jun 27, 2022

kskovpen commented Jun 28, 2022

AdrianoDee commented Jun 28, 2022

cmsbuild commented Jun 28, 2022

perrotta commented Jun 28, 2022

AdrianoDee commented Jun 24, 2022 •

edited

Loading

AdrianoDee Jun 24, 2022 •

edited

Loading

AdrianoDee Jun 24, 2022 •

edited

Loading