Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Adding BPH wfs to relval matrix #38495

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented Jun 24, 2022

This is a backport of #38397 and #38494. It adds to the the list of the upgrade wfs to be used in the release validation studies the following fragments:

  • BuToJPsiPrimeKToJPsiPiPiK
  • Psi2SToJPsiPiPi
  • XiMinus_14TeV
  • Chib1PToUpsilon1SGamma
  • ChicToJpsiGamma

Note that, if #38467 goes in, the naming, the number of events and jobs will be changed accordingly for the Xi wf.

PR validation:

Tested with 11715.0, 11716.0, 11717.0, 11718.0, 11719.0.
Tested with 11739.0, 11740.0, 11741.0, 11742.0, 11743.0.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2022

A new Pull Request was created by @AdrianoDee for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • workflow = 11715.0,11716.0,11717.0,11718.0,11719.0

@jordan-martins
Copy link
Contributor

+1

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1eac1/25761/summary.html
COMMIT: abfd3f3
CMSSW: CMSSW_12_4_X_2022-06-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38495/25761/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 11725.0DAS Error
  • 11925.0DAS Error

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3680329
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

- BuToJPsiPrimeKToJPsiPiPiK
- Psi2SToJPsiPiPi
- XiMinus_14TeV
- Chib1PToUpsilon1SGamma
- ChicToJpsiGamma
- Restoring proper ordering, updating to 13p6
@cmsbuild
Copy link
Contributor

Pull request #38495 was updated. @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

@AdrianoDee
Copy link
Contributor Author

test parameters:

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1eac1/25771/summary.html
COMMIT: e241b7b
CMSSW: CMSSW_12_4_X_2022-06-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38495/25771/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3680329
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

backport of #38494

@perrotta
Copy link
Contributor

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 is this needed for 12_4_1?

@kskovpen
Copy link
Contributor

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 is this needed for 12_4_1?

These workflows were added for them to be included in the next release validation campaigns, and therefore we don't need them in 12_4_1.

@mmusich
Copy link
Contributor

mmusich commented Jun 28, 2022

These workflows were added for them to be included in the next release validation campaigns, and therefore we don't need them in 12_4_1.

@kskovpen @AdrianoDee wouldn't they be desirable to check the "revert to CKF for pixel-less" thingy?

@AdrianoDee
Copy link
Contributor Author

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 is this needed for 12_4_1?

These workflows were added for them to be included in the next release validation campaigns, and therefore we don't need them in 12_4_1.

Hi @kskovpen couldn't this help for the incoming validation production for the mkfit pixelles rollback?

@kskovpen
Copy link
Contributor

Hi All, could you remind me which JIRA is that (if any)?

@mmusich
Copy link
Contributor

mmusich commented Jun 28, 2022

@kskovpen
Copy link
Contributor

Thanks! Then I take it back. Needed for 12_4_1.

@mmusich
Copy link
Contributor

mmusich commented Jun 28, 2022

Needed for 12_4_1.

could you sign it, then :) ? Thanks a lot.

@kskovpen
Copy link
Contributor

Gosh! I am in anarchy mode today, sorry! Signing

@kskovpen
Copy link
Contributor

+pdmv

@jordan-martins
Copy link
Contributor

@AdrianoDee please, sign as upgrade :)
12_4_1 is on the verge to be built

@AdrianoDee
Copy link
Contributor Author

+upgrade

Adding bph wf to relvals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 91210bf into cms-sw:CMSSW_12_4_X Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants