Code Fix to read tower geometry correctly in Ecal DQM StatusManager [Master]

[abhih1]

PR description:

This PR fixes the code to read tower geometry correctly in Ecal DQM StatusManager.
Additionally the toGet method of accessing the DB tags is removed from the Ecal DQM config, on the suggestion of AlcaDB.

PR validation:

PR is validated by running a local test which creates an sqlite file which is uploaded to the DB and verified with an online DQM run on a test DQM GUI. Everything looks as expected.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is the Master PR. The backport to 12_4_X is #38359 and 12_3_X is #38360

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38357/30546

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38357/30546/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38357/30546/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38357/30547

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @abhih1 (Abhirami Harilal) for master.

It involves the following packages:

• DQM/EcalCommon (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38357/30549

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #38357 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[emanueleusai]

please test

[emanueleusai]

type ecal

[tvami]

Sorry can somebody elaborate on how this PR adds the tags in the title of the PR? And why this isnt happening through a GT? Thanks!

[abhih1]

Hi @tvami
The changes made here is essentially to create a local sqlite file with the correct tower and channel status info, which is then uploaded to the DB manually (using local scripts). I have updated the PR description to be more clear. Sorry for the confusion!
Despite the names having "hlt" in them they are not really hlt tags and their update has been done manually this way.
The last time this was updated was in 2016 and the relevant codes didnt seem to work anymore and this PR makes them functional again to create the sqlite file with the correct tower mapping, and also updates the tower list.

Hope this answers your question.

[tvami]

@cmsbuild , please test with #38455

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdfa87/25672/summary.html
COMMIT: 2087609
CMSSW: CMSSW_12_5_X_2022-06-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38357/25672/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3659099
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3659075
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass
• changes are according to the review, the description will have to be rewritten
• Update HLT GT with ECAL DQM tower and channel status tags #38455 should merge first

[tvami]

hi @abhih1
please rewrite the PR description according to the requested changes (e.g. there is no local sqlite anymore).

Also

if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A

Well that's very far from the truth given that you already did the 12_3_X and 12_4_X backports, please also comment on the urgency about deploying this at the online machines

[abhih1]

hi @abhih1 please rewrite the PR description according to the requested changes (e.g. there is no local sqlite anymore).

Hi @tvami, sure but could you please explain to me how these tags will be updated, now that they are added to the GT? Next time we need to update the towers what is the procedure to follow if there's no local sqlite file anymore?

Also

if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A

Well that's very far from the truth given that you already did the 12_3_X and 12_4_X backports, please also comment on the urgency about deploying this at the online machines

Well I thought the question is whether this is a backport, which it is not as this is the Original PR, and in the actual backport PRs to 12_3_X and 12_4_X I do mention it in the description. But if you'd like I can mention the backport PRs here as well.

[tvami]

Next time we need to update the towers what is the procedure to follow if there's no local sqlite file anymore?

The ECAL AlCaDB contacts will know the procedure. But it's: you create your sqlite file, the contact uploads with a good name as a single-iov tag, we do a DQM replay with it, after making sure everything is fine, the contact makes an append to these multi-iov tags. No need to change the code

But if you'd like I can mention the backport PRs here as well.

I usually prefer to show in the master that there are backports, because, according to the ORP policy, the master will have to be always merged first, so if there are backports, the urgency of merging the master is higher, given that the real usage is in the backport. I can discuss with ORP about the meaning of this, indeed that text is starting with "if this is a backport"

[abhih1]

Ok thanks. I've updated the description

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Update HLT GT with ECAL DQM tower and channel status tags #38455 is already merged