Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Herwig6Interface, MCatNLOInterface, PomwigInterface #37612

Merged

Conversation

iarspider
Copy link
Contributor

PR description:

Drop Herwig6Interface, MCatNLOInterface and PomwigInterface due to removal of legacy MC generators (cms-sw/cmsdist#7763).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for CMSSW_12_4_DEVEL_X.

It involves the following packages:

  • GeneratorInterface/Herwig6Interface (generators)
  • GeneratorInterface/MCatNLOInterface (generators)
  • GeneratorInterface/PomwigInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmsdist#7763

@iarspider
Copy link
Contributor Author

please abort

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmsdist#7763

@cmsbuild
Copy link
Contributor

Pull request #37612 was updated. @SiewYan, @smuzaffar, @Dr15Jones, @mkirsano, @makortel, @Saptaparna, @GurpreetSinghChahal, @alberto-sanchez, @santocch can you please check and sign again.

@iarspider
Copy link
Contributor Author

(last commit should read "... for herwig6")

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6d550/24001/summary.html
COMMIT: 41bf902
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-18-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37612/24001/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6d550/24001/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6d550/24001/git-merge-result

Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: PhotosInterface.cc:(.text+0x29fe): undefined reference to `hepevt_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosInterfaceDefault/PhotosInterface.cc.o: in function `HepMC::HEPEVT_Wrapper::byte_num_to_double(unsigned int)':
PhotosInterface.cc:(.text._ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj[_ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj]+0x138): undefined reference to `hepevt_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: PhotosInterface.cc:(.text._ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj[_ZN5HepMC14HEPEVT_Wrapper18byte_num_to_doubleEj]+0x153): undefined reference to `hepevt_'
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-unknown-linux-gnu/10.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosInterfaceDefault/PhotosInterface.cc.o:PhotosInterface.cc:(.text._ZN5HepMC14HEPEVT_Wrapper15byte_num_to_intEj[_ZN5HepMC14HEPEVT_Wrapper15byte_num_to_intEj]+0xa3): more undefined references to `hepevt_' follow
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosInterfaceDefault/libPhotosInterfaceDefault.so] Error 1
Leaving library rule at src/GeneratorInterface/PhotosInterface/plugins
Entering library rule at src/GeneratorInterface/PhotosInterface/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_DEVEL_X_2022-04-18-2300/src/GeneratorInterface/PhotosInterface/plugins/PhotosppInterface.cc
>> Building  edm plugin tmp/slc7_amd64_gcc10/src/GeneratorInterface/PhotosInterface/plugins/PhotosppInterface/libPhotosppInterface.so


@iarspider
Copy link
Contributor Author

please test

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmsdist#7806

@iarspider
Copy link
Contributor Author

please abort

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmsdist#7806

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6d550/24061/summary.html
COMMIT: 41bf902
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37612/24061/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6d550/24061/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6d550/24061/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e6d550/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3589937
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3589907
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@cms-sw/generators-l2 , I suggest that we merge this (along with cmsdist PRs) in DEVEL IBs to test full runTheMatrix. If DEVEL IBs show no failure then we can backport these for master branch.

@smuzaffar
Copy link
Contributor

@qliphy @perrotta , we would like to test these changes first in DEVEL IBs, if @cms-sw/generators-l2 has no objections then please include these for next DEVEL IBs ( along with the cmsdist PRs)

@qliphy
Copy link
Contributor

qliphy commented Apr 21, 2022

merge
to test for next DEVEL IBs

@cmsbuild cmsbuild merged commit 1a94a71 into cms-sw:CMSSW_12_4_DEVEL_X Apr 21, 2022
iarspider added a commit to iarspider-cmssw/cmssw that referenced this pull request May 5, 2022
@santocch
Copy link

santocch commented May 5, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants