-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify VVIObjF
object so it takes kappa
only in the constructor
#37533
Conversation
type performance-improvements |
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37533/29245
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Except for #37533 (comment) , I changed the PR according to the review, and tested again. It ran fine. |
@cmsbuild , please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37533/29246
|
Pull request #37533 was updated. @jpata, @clacaputo, @slava77 can you please check and sign again. |
@smuzaffar profiling has been running for a long time now (14hours), is that expected? |
@smuzaffar so it's been 2 days now, can you look into this please? |
@tvami , profiling job is still running for last 16h , may be igprof is hanging somewhere. Since 5am this morning it is running
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-980085/23921/summary.html Comparison SummarySummary:
|
The reduction in the CPU usage looks sizeable if these numbers are trustable. Wondering why 2021 simulation does not get down, though. |
Indeed this is surprising to see. Maybe due to some other changes in the IBs? Should we test again? |
This is more in line with my naive expectations, I would have expected that the bulk of the CPU is taken from evaluating all those trigonometric functions, hence was wondering if the cumulative numbers were trustable. |
Hi @cms-sw/reconstruction-l2 shall this PR be merged? Or I should just close it given that it didn't live up to its expectation? :D |
why? even if small, it's better than nothing. |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
type tracking |
type -tracking |
type trk |
PR description:
Resolution to the issue #37529
vvidist
was essentially taking 1 parameter so far as well (kappa
), now there is a constructor for it that does that alone.PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
Resolves #37529