Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PhotosInterface, support for tauola 27.x from TauolaInterface #37616

Merged
merged 1 commit into from
Apr 24, 2022
Merged

Drop PhotosInterface, support for tauola 27.x from TauolaInterface #37616

merged 1 commit into from
Apr 24, 2022

Conversation

iarspider
Copy link
Contributor

PR description:

Drop PhotosInterface due to removal of legacy MC generators (cms-sw/cmsdist#7763).

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for CMSSW_12_4_DEVEL_X.

It involves the following packages:

  • GeneratorInterface/ExternalDecays (generators)
  • GeneratorInterface/PhotosInterface (generators)

@alberto-sanchez, @SiewYan, @mkirsano, @Saptaparna, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

This was referenced Apr 19, 2022
Closed
Closed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab67de/24004/summary.html
COMMIT: 68c5ba4
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-18-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37616/24004/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab67de/24004/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab67de/24004/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2970 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3589937
  • DQMHistoTests: Total failures: 6317
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3583597
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 47 workflows

@iarspider
Copy link
Contributor Author

please test with #37612,cms-sw/cmsdist#7807

@iarspider iarspider closed this Apr 20, 2022
@iarspider iarspider reopened this Apr 20, 2022
@iarspider iarspider changed the title Drop PhotosInterface Drop PhotosInterface, support for tauola 27.x from TauolaInterface Apr 20, 2022
@iarspider
Copy link
Contributor Author

please test with cms-sw/cmsdist#7807

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmsdist#7807,cms-sw/cmsdist#7806

1 similar comment
@iarspider
Copy link
Contributor Author

please test with cms-sw/cmsdist#7807,cms-sw/cmsdist#7806

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmsdist#7807,cms-sw/cmsdist#7806,#37612

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab67de/24091/summary.html
COMMIT: 68c5ba4
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37616/24091/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab67de/24091/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab67de/24091/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ab67de/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2972 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 6318
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3689094
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@smuzaffar
Copy link
Contributor

@cms-sw/generators-l2 , I suggest that we merge this (along with cmsdist PRs) in DEVEL IBs to test full runTheMatrix. If DEVEL IBs show no failure then we can backport these for master branch.

@smuzaffar
Copy link
Contributor

@qliphy @perrotta , we would like to test these changes first in DEVEL IBs, if @cms-sw/generators-l2 has no objections then please include these for next DEVEL IBs ( along with the cmsdist PRs)

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#7807

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab67de/24167/summary.html
COMMIT: 68c5ba4
CMSSW: CMSSW_12_4_DEVEL_X_2022-04-22-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37616/24167/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab67de/24167/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab67de/24167/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ab67de/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2973 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 6323
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3689088
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@perrotta
Copy link
Contributor

@cms-sw/generators-l2 do you have any objection in merging these PRs in the devel branch (not yet in the main release)?

@Saptaparna
Copy link
Contributor

No objections. +1

@perrotta perrotta mentioned this pull request Apr 24, 2022
Merged
@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c1169e0 into cms-sw:CMSSW_12_4_DEVEL_X Apr 24, 2022
@iarspider iarspider mentioned this pull request Apr 25, 2022
Merged
iarspider added a commit to iarspider-cmssw/cmssw that referenced this pull request May 5, 2022
@iarspider
[Forward port] Drop references to legacy generators
a641751 
Original PRs: cms-sw#37610, cms-sw#37611, cms-sw#37612, cms-sw#37616;
cmsdist PR: todo
@iarspider iarspider mentioned this pull request May 5, 2022
Merged
@cmsbuild cmsbuild mentioned this pull request Oct 18, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Nov 17, 2023
Closed
@iarspider iarspider deleted the drop-photos_f-tauola_f branch February 27, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
generators-pending orp-approved pending-signatures requires-external tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iarspider @cmsbuild @smuzaffar @perrotta @Saptaparna